linux-kernel - Re: [PATCH bpf v2] lib/buildid: use __kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251218132116.c1edb3ee6688605bd270a666@linux-foundation.org>
Date: Thu, 18 Dec 2025 13:21:16 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: Matthew Wilcox <willy@...radead.org>, Andrii Nakryiko
 <andrii@...nel.org>, Shaurya Rane <ssrane_b23@...vjti.ac.in>,
 "Darrick J . Wong" <djwong@...nel.org>, Christoph Hellwig
 <hch@...radead.org>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
 <daniel@...earbox.net>, Meta kernel team <kernel-team@...a.com>,
 bpf@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org,
 syzbot+09b7d050e4806540153d@...kaller.appspotmail.com, Christoph Hellwig
 <hch@....de>
Subject: Re: [PATCH bpf v2] lib/buildid: use __kernel_read() for sleepable
 context

On Thu, 18 Dec 2025 12:55:05 -0800 Shakeel Butt <shakeel.butt@...ux.dev> wrote:

> For the sleepable context, convert freader to use __kernel_read()
> instead of direct page cache access via read_cache_folio(). This
> simplifies the faultable code path by using the standard kernel file
> reading interface which handles all the complexity of reading file data.
> 
> At the moment we are not changing the code for non-sleepable context
> which uses filemap_get_folio() and only succeeds if the target folios
> are already in memory and up-to-date. The reason is to keep the patch
> simple and easier to backport to stable kernels.
> 
> Syzbot repro does not crash the kernel anymore and the selftests run
> successfully.
> 
> In the follow up we will make __kernel_read() with IOCB_NOWAIT work for
> non-sleepable contexts. In addition, I would like to replace the
> secretmem check with a more generic approach and will add fstest for the
> buildid code.
> 
> Reported-by: syzbot+09b7d050e4806540153d@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=09b7d050e4806540153d
> Fixes: ad41251c290d ("lib/buildid: implement sleepable build_id_parse() API")

v6.12.

> Reviewed-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Shakeel Butt <shakeel.butt@...ux.dev>

Thanks, I'll add cc:stable to this due to "crashes the kernel".