linux-kernel - Re: [PATCH v3 2/2] hwmon: temperature: add support for EMC1812

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <978d7a38-787a-4b84-be58-d2784ebfcf6f@roeck-us.net>
Date: Thu, 18 Dec 2025 14:35:36 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Marius Cristea <marius.cristea@...rochip.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 2/2] hwmon: temperature: add support for EMC1812

On 12/18/25 05:48, Marius Cristea wrote:
> This is the devicetree schema for Microchip EMC1812/13/14/15/33
> Multichannel Low-Voltage Remote Diode Sensor Family.
> 
> EMC1812 has one external remote temperature monitoring channel.
> EMC1813 has two external remote temperature monitoring channels.
> EMC1814 has three external remote temperature monitoring channels and
> channels 2 and 3 supports anti parallel diode.
> EMC1815 has four external remote temperature monitoring channels and
> channels 1/2  and 3/4 supports anti parallel diode.
> EMC1833 has two external remote temperature monitoring channels and
> channels 1 and 2 supports anti parallel diode.
> 
> Signed-off-by: Marius Cristea <marius.cristea@...rochip.com>

A quick module test run shows:

temp1_crit_alarm: bad permissions: -rw-r--r--, expected -r--r--r--
temp1_input: bad permissions: -rw-r--r--, expected -r--r--r--
temp1_max_alarm: bad permissions: -rw-r--r--, expected -r--r--r--
temp1_max_hyst: bad permissions: -rw-r--r--, expected -r--r--r--
temp1_min_alarm: bad permissions: -rw-r--r--, expected -r--r--r--
temp1_min_hyst: bad permissions: -rw-r--r--, expected -r--r--r--

for all alarms and temperature readings. Indeed, the driver
sets that. Please fix.

Also, I get

temp1_crit: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp1_crit_hyst: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp1_min: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp1_max: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp2_crit: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp2_crit_hyst: Suspected underflow: [min=-74000, read -64000, written -2147483648]
temp3_crit: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp3_crit_hyst: min [-64000] is equal to max [-64000]

I'll need to track that down unless you find the probem before I do.

Thanks,
Guenter