linux-kernel - Re: [PATCH 6/7] gpu: nova-core: send UNLOADING_GUEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3fcbf9b9165da51c05dd2837adaa0be2ae1f05d.camel@nvidia.com>
Date: Thu, 18 Dec 2025 23:34:30 +0000
From: Timur Tabi <ttabi@...dia.com>
To: Joel Fernandes <joelagnelf@...dia.com>
CC: "gary@...yguo.net" <gary@...yguo.net>, "lossin@...nel.org"
	<lossin@...nel.org>, "a.hindborg@...nel.org" <a.hindborg@...nel.org>,
	"boqun.feng@...il.com" <boqun.feng@...il.com>, "ojeda@...nel.org"
	<ojeda@...nel.org>, "simona@...ll.ch" <simona@...ll.ch>, "tmgross@...ch.edu"
	<tmgross@...ch.edu>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
	"bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>, Eliot Courtney
	<ecourtney@...dia.com>, "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"kwilczynski@...nel.org" <kwilczynski@...nel.org>, Alexandre Courbot
	<acourbot@...dia.com>, "dakr@...nel.org" <dakr@...nel.org>, Alistair Popple
	<apopple@...dia.com>
Subject: Re: [PATCH 6/7] gpu: nova-core: send UNLOADING_GUEST_DRIVER GSP
 command GSP upon unloading

On Thu, 2025-12-18 at 22:44 +0000, Joel Fernandes wrote:
> > Isn't the real problem that we are polling for a specific message, when all message should be
> > handled asynchronously as events, like Nouveau does?
> > 
> >           Err(ERANGE) => continue,
> > 
> > This effectively throws out all other messages, including errors and anything else important.
> > 
> 
> Indeed, for that we need Interrupts. For the rest of the patterns where we need the message
> synchronously, we should bound this. Hanging in the driver is unacceptable.

It's going to be difficulty to have a running asynchronous message handler in the background *and*
poll synchronously for a specific message on occasional.  I would say that even in this case, we
should handle the message asynchronously.  So instead of polling on the message queue, we just wait
on a semaphore, with a timeout.

> Interrupts are almost here now, considering we/others have upstreamed all the required patches for
> Rust interrupt support.

So my suggestion is that we don't overcomplicate this code today, since it's all going to be ripped
out later.