linux-kernel - Re: [PATCH] tracing: Remove size parameter in __trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUR4pJLYdNs4Zo-Z@yury>
Date: Thu, 18 Dec 2025 16:56:52 -0500
From: Yury Norov <yury.norov@...il.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
	Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH] tracing: Remove size parameter in __trace_puts()

On Thu, Dec 18, 2025 at 04:37:39PM -0500, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@...dmis.org>
> 
> The __trace_puts() function takes a string pointer and the size of the
> string itself. All users currently simply pass in the strlen() of the
> string it is also passing in. There's no reason to pass in the size.
> Instead have the __trace_puts() function do the strlen() within the
> function itself.
> 
> This fixes a header recursion issue where using strlen() in the macro
> calling __trace_puts() requires adding #include <linux/string.h> in order
> to use strlen(). Removing the use of strlen() from the header fixes the
> recursion issue.
> 
> Link: https://lore.kernel.org/all/aUN8Hm377C5A0ILX@yury/
> 
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>

Thanks, Steven. I'll take it with v4 of the above.

Thanks,
Yury