linux-kernel - Re: [PATCH] kunit: fix up const mis-match in many assert functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABVgOSmVk3Jo=fXh4M+vM3KOPqWW6vqxfj_=-NhkbSutc_Spcg@mail.gmail.com>
Date: Thu, 18 Dec 2025 14:12:25 +0800
From: David Gow <davidgow@...gle.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: brendan.higgins@...ux.dev, linux-kernel@...r.kernel.org, 
	Rae Moar <raemoar63@...il.com>, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com
Subject: Re: [PATCH] kunit: fix up const mis-match in many assert functions

On Wed, 17 Dec 2025 at 20:33, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> In many kunit assert functions a const pointer is passed to
> container_of() and out pops a non-const pointer, which really isn't the
> correct thing to do at all.  Fix this up by correctly marking the
> casted-to pointer as const to preserve the marking.
>
> Cc: Brendan Higgins <brendan.higgins@...ux.dev>
> Cc: David Gow <davidgow@...gle.com>
> Cc: Rae Moar <raemoar63@...il.com>
> Cc: linux-kselftest@...r.kernel.org
> Cc: kunit-dev@...glegroups.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---

Nice catch, thanks!

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David


>  lib/kunit/assert.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lib/kunit/assert.c b/lib/kunit/assert.c
> index 867aa5c4bccf..4c751ad8506a 100644
> --- a/lib/kunit/assert.c
> +++ b/lib/kunit/assert.c
> @@ -51,7 +51,7 @@ void kunit_unary_assert_format(const struct kunit_assert *assert,
>                                const struct va_format *message,
>                                struct string_stream *stream)
>  {
> -       struct kunit_unary_assert *unary_assert;
> +       const struct kunit_unary_assert *unary_assert;
>
>         unary_assert = container_of(assert, struct kunit_unary_assert, assert);
>
> @@ -71,7 +71,7 @@ void kunit_ptr_not_err_assert_format(const struct kunit_assert *assert,
>                                      const struct va_format *message,
>                                      struct string_stream *stream)
>  {
> -       struct kunit_ptr_not_err_assert *ptr_assert;
> +       const struct kunit_ptr_not_err_assert *ptr_assert;
>
>         ptr_assert = container_of(assert, struct kunit_ptr_not_err_assert,
>                                   assert);
> @@ -117,7 +117,7 @@ void kunit_binary_assert_format(const struct kunit_assert *assert,
>                                 const struct va_format *message,
>                                 struct string_stream *stream)
>  {
> -       struct kunit_binary_assert *binary_assert;
> +       const struct kunit_binary_assert *binary_assert;
>
>         binary_assert = container_of(assert, struct kunit_binary_assert,
>                                      assert);
> @@ -145,7 +145,7 @@ void kunit_binary_ptr_assert_format(const struct kunit_assert *assert,
>                                     const struct va_format *message,
>                                     struct string_stream *stream)
>  {
> -       struct kunit_binary_ptr_assert *binary_assert;
> +       const struct kunit_binary_ptr_assert *binary_assert;
>
>         binary_assert = container_of(assert, struct kunit_binary_ptr_assert,
>                                      assert);
> @@ -185,7 +185,7 @@ void kunit_binary_str_assert_format(const struct kunit_assert *assert,
>                                     const struct va_format *message,
>                                     struct string_stream *stream)
>  {
> -       struct kunit_binary_str_assert *binary_assert;
> +       const struct kunit_binary_str_assert *binary_assert;
>
>         binary_assert = container_of(assert, struct kunit_binary_str_assert,
>                                      assert);
> @@ -237,7 +237,7 @@ void kunit_mem_assert_format(const struct kunit_assert *assert,
>                              const struct va_format *message,
>                              struct string_stream *stream)
>  {
> -       struct kunit_mem_assert *mem_assert;
> +       const struct kunit_mem_assert *mem_assert;
>
>         mem_assert = container_of(assert, struct kunit_mem_assert,
>                                   assert);
> --
> 2.52.0
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5281 bytes)