linux-kernel - Re: [PATCH] Revert "scripts/clang-tools: Handle included .c files in gen_compile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACT4Y+Z5Mtax6BMtpY6Zj9Zd_1XjphfkMDp_3Wrzo94Pw9=VhA@mail.gmail.com>
Date: Thu, 18 Dec 2025 08:03:47 +0100
From: Dmitry Vyukov <dvyukov@...gle.com>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Nicolas Schier <nsc@...nel.org>, Nick Desaulniers <nick.desaulniers+lkml@...il.com>, 
	Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>, linux-kbuild@...r.kernel.org, 
	llvm@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "scripts/clang-tools: Handle included .c files in gen_compile_commands"

On Thu, 18 Dec 2025 at 01:13, Nathan Chancellor <nathan@...nel.org> wrote:
>
> On Wed, Dec 17, 2025 at 08:13:43PM +0100, Nicolas Schier wrote:
> > This reverts commit 9362d34acf91a706c543d919ade3e651b9bd2d6f.
> >
> > Dmitry Vyukov reported that commit 9362d34acf91 ("scripts/clang-tools:
> > Handle included .c files in gen_compile_commands") generates false
> > entries in some cases for C files that are included in other C files but
> > not meant for standalone compilation.
> >
> > For properly forking clangd, including .c files is discouraged.
> >
> > Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> > Closes: https://lore.kernel.org/r/CACT4Y+Z8aCz0XcoJx9XXPHZSZHxGF8Kx9iUbFarhpTSEPDhMfg@mail.gmail.com
> > Signed-off-by: Nicolas Schier <nsc@...nel.org>
>
> Acked-by: Nathan Chancellor <nathan@...nel.org>

Acked-by: Dmitry Vyukov <dvyukov@...gle.com>

Thanks!