linux-kernel - Re: [PATCH v5 1/2] dt-bindings: media: i2c: Add os05b10 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251218-adorable-poetic-chamois-c5ed5a@quoll>
Date: Thu, 18 Dec 2025 08:31:26 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
Cc: robh@...nel.org, krzk+dt@...nel.org, sakari.ailus@...ux.intel.com, 
	Elgin Perumbilly <elgin.perumbilly@...iconsignals.io>, Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Hans Verkuil <hverkuil@...nel.org>, Hans de Goede <hansg@...nel.org>, 
	Mehdi Djait <mehdi.djait@...ux.intel.com>, Ricardo Ribalda <ribalda@...omium.org>, 
	André Apitzsch <git@...tzsch.eu>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
	Dongcheng Yan <dongcheng.yan@...el.com>, Sylvain Petinot <sylvain.petinot@...s.st.com>, 
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>, Bryan O'Donoghue <bryan.odonoghue@...aro.org>, 
	Heimir Thor Sverrisson <heimir.sverrisson@...il.com>, Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>, 
	Svyatoslav Ryhel <clamor95@...il.com>, linux-media@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: media: i2c: Add os05b10 sensor

On Tue, Dec 16, 2025 at 12:29:49PM +0530, Himanshu Bhavani wrote:
> +        properties:
> +          data-lanes:
> +            oneOf:
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +                  - const: 3
> +                  - const: 4
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +        required:
> +          - data-lanes
> +          - link-frequencies
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - avdd-supply
> +  - dovdd-supply
> +  - dvdd-supply
> +  - port

Your driver clearly says reset gpio is not optional. Did you test the
code without reset-gpios?

You already got exactly the same comment on other patchset.


Best regards,
Krzysztof