linux-kernel - Re: [PATCH] s390/spinlock: Replace simple_strtoul with kstrtouint in spin_retry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35571508-723e-482c-a729-6ffccaae14e7-agordeev@linux.ibm.com>
Date: Thu, 18 Dec 2025 08:59:03 +0100
From: Alexander Gordeev <agordeev@...ux.ibm.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        joel granados <joel.granados@...nel.org>,
        Juergen Christ <jchrist@...ux.ibm.com>, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/spinlock: Replace simple_strtoul with kstrtouint in
 spin_retry_setup

On Sat, Dec 13, 2025 at 01:32:44PM +0100, Thorsten Blum wrote:
> Replace simple_strtoul() with the recommended kstrtouint() for parsing
> the 'spin_retry=' boot parameter. Unlike simple_strtoul(), which returns
> an unsigned long, kstrtouint() converts the string directly to an
> unsigned integer.
> 
> Check the return value of kstrtouint() and reject invalid values. This
> adds error handling while preserving existing behavior for valid values,
> and removes use of the deprecated simple_strtoul() helper.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  arch/s390/lib/spinlock.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/s390/lib/spinlock.c b/arch/s390/lib/spinlock.c
> index 10db1e56a811..b4ca53356b96 100644
> --- a/arch/s390/lib/spinlock.c
> +++ b/arch/s390/lib/spinlock.c
> @@ -34,8 +34,7 @@ early_initcall(spin_retry_init);
>   */
>  static int __init spin_retry_setup(char *str)
>  {
> -	spin_retry = simple_strtoul(str, &str, 0);
> -	return 1;
> +	return kstrtouint(str, 0, &spin_retry) == 0;

Why not to use kstrtouint() return value, like other parameters do?

>  }
>  __setup("spin_retry=", spin_retry_setup);
>  
> -- 
> Thorsten Blum <thorsten.blum@...ux.dev>

Thanks!