[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aUNRS1Qiaiqo1scX@kbusch-mbp>
Date: Thu, 18 Dec 2025 08:56:43 +0800
From: Keith Busch <kbusch@...nel.org>
To: veygax <veyga@...gax.dev>
Cc: Ming Lei <ming.lei@...hat.com>, Jens Axboe <axboe@...nel.dk>,
"io-uring@...r.kernel.org" <io-uring@...r.kernel.org>,
Caleb Sander Mateos <csander@...estorage.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] io_uring/rsrc: fix slab-out-of-bounds in
io_buffer_register_bvec
On Thu, Dec 18, 2025 at 12:37:47AM +0000, veygax wrote:
> /*
> * Add pages to bio manually.
> * We use physically contiguous pages to trick blk_rq_nr_phys_segments
> * into returning 1 segment.
> * We use multiple bvec entries to trick the loop in io_buffer_register_bvec
> * into writing out of bounds.
> */
> for (i = 0; i < num_bvecs; i++) {
> struct bio_vec *bv = &bio->bi_io_vec[i];
> bv->bv_page = page + i;
> bv->bv_len = PAGE_SIZE;
> bv->bv_offset = 0;
> bio->bi_vcnt++;
> bio->bi_iter.bi_size += PAGE_SIZE;
> }
I believe you're supposed to use the bio_add_page() API rather than open
code the bvec setup.
Powered by blists - more mailing lists