linux-kernel - Re: [PATCH v2 4/4] arm64: dts: qcom: lemans-evk: Enable USB1 controller for host mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251218-winged-hypnotic-jellyfish-370cda@quoll>
Date: Thu, 18 Dec 2025 09:14:41 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Swati Agarwal <swati.agarwal@....qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Icenowy Zheng <uwu@...nowy.me>, 
	J . Neuschäfer <j.ne@...teo.net>, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, 
	Jens Glathe <jens.glathe@...schoolsolutions.biz>, Mike Looijmans <mike.looijmans@...ic.nl>, 
	Pin-yen Lin <treapking@...omium.org>, Catalin Popescu <catalin.popescu@...ca-geosystems.com>, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	linux-usb@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: lemans-evk: Enable USB1
 controller for host mode

On Tue, Dec 16, 2025 at 05:37:49PM +0530, Swati Agarwal wrote:
> Enable USB1 controller for host mode on EVK Platform.
> 
> For secondary USB Typec port, there is a genesys USB HUB GL3590 having 4
> ports sitting in between SOC and HD3SS3220 Type-C port controller and SS
> lines run from the SoC through the hub to the Port controller. Mark the
> second USB controller as host only capable.
> 
> Added HD3SS3220 Type-C port controller along with Type-c connector for


"Add". Write consistent messages.

> controlling vbus supply.

...

> +			port@1 {
> +				reg = <1>;
> +
> +				usb1_hs_in: endpoint {
> +					remote-endpoint = <&usb_hub_2_1>;
> +				};
> +
> +			};
> +
> +			port@2 {
> +				reg = <2>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				usb1_ss_in: endpoint {
> +					remote-endpoint = <&usb_hub_3_1>;
> +				};
> +
> +			};
> +		};
> +	};
> +
>  	edp0-connector {
>  		compatible = "dp-connector";
>  		label = "EDP0";
> @@ -140,6 +182,16 @@ vbus_supply_regulator_0: regulator-vbus-supply-0 {
>  		enable-active-high;
>  	};
>  
> +	vbus_supply_regulator_1: vbus-supply-regulator-1 {

No, do not introduce your own style. Read the code here - how such
nodes are called?

Best regards,
Krzysztof