linux-kernel - Re: [PATCH] ASoC: cs-amp-lib: Replace __free(kfree) with normal kfree() cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176604606576.48417.12415715226763234194.b4-ty@kernel.org>
Date: Thu, 18 Dec 2025 08:21:05 +0000
From: Mark Brown <broonie@...nel.org>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, 
 patches@...nsource.cirrus.com
Subject: Re: [PATCH] ASoC: cs-amp-lib: Replace __free(kfree) with normal
 kfree() cleanup

On Mon, 01 Dec 2025 12:39:06 +0000, Richard Fitzgerald wrote:
> Replace the use of __free(kfree) in _cs_amp_set_efi_calibration_data()
> with normal kfree() at the end of the function.
> 
> Krzysztof Kozlowski pointed out that __free() can be dangerous.
> It can introduce new cleanup bugs. These are more subtle and difficult to
> spot than a missing goto in traditional cleanup, because they are triggered
> by writing regular idiomatic C code instead of using C++ conventions. As
> it's regular C style it's more likely to be missed because the code is as
> would be expected for C. The traditional goto also more obviously flags
> to anyone changing the code in the future that they must be careful about
> the cleanup.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs-amp-lib: Replace __free(kfree) with normal kfree() cleanup
      commit: 9a123f222e1889d020d873aa6e0799098d22cdb1

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark