linux-kernel - Re: [PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251218-fresh-fair-pigeon-aaeca0@quoll>
Date: Thu, 18 Dec 2025 09:12:05 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: David Heidelberg <david@...t.cz>
Cc: Robert Foss <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>, 
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>, Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Vikram Sharma <quic_vikramsa@...cinc.com>, Kapatrala Syed <akapatra@...cinc.com>, 
	Hariram Purushothaman <hariramp@...cinc.com>, Richard Acayan <mailingradian@...il.com>, 
	Bryan O'Donoghue <bod@...nel.org>, Hans Verkuil <hverkuil@...nel.org>, 
	Depeng Shao <quic_depengs@...cinc.com>, linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply
 description

On Tue, Dec 16, 2025 at 01:24:50PM +0100, David Heidelberg wrote:
> Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
> voltage from the description.

You did not remove the voltage. Anyway, both commits should be squashed.

> 
> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
>  Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> index 019caa2b09c32..4986d18d1a2da 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> @@ -130,7 +130,7 @@ properties:
>  
>    vdda-pll-supply:
>      description:
> -      Phandle to 1.8V regulator supply to PHY refclk pll block.
> +      1.2V regulator supply to CSIPHY IP blocks.

"...that supply is a regulator supply" so you still decided to go that
way. Why? I think I could not write this clearer.

Best regards,
Krzysztof