linux-kernel - [PATCH] node: fix a api misuse in node_init_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251218085251.555749-1-lihaoxiang@isrc.iscas.ac.cn>
Date: Thu, 18 Dec 2025 16:52:51 +0800
From: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
To: gregkh@...uxfoundation.org,
	rafael@...nel.org,
	dakr@...nel.org,
	Jonathan.Cameron@...wei.com,
	kbusch@...nel.org
Cc: linux-kernel@...r.kernel.org,
	Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>,
	stable@...r.kernel.org
Subject: [PATCH] node: fix a api misuse in node_init_node_access()

If device_register() fails, put_device() is the correct way to
cleanup the resource.
And free the dev name is unnecessary.

Fixes: 08d9dbe72b1f ("node: Link memory nodes to their compute nodes")
Cc: stable@...r.kernel.org
Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
---
 drivers/base/node.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index 00cf4532f121..28c89ad67d0b 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -170,14 +170,15 @@ static struct node_access_nodes *node_init_node_access(struct node *node,
 	if (dev_set_name(dev, "access%u", access))
 		goto free;
 
-	if (device_register(dev))
-		goto free_name;
+	if (device_register(dev)) {
+		put_device(dev);
+		return NULL;
+	}
 
 	pm_runtime_no_callbacks(dev);
 	list_add_tail(&access_node->list_node, &node->access_list);
 	return access_node;
-free_name:
-	kfree_const(dev->kobj.name);
+
 free:
 	kfree(access_node);
 	return NULL;
-- 
2.25.1