linux-kernel - Re: [PATCH net-next v1 2/3] dt-bindings: net: micrel: Add keep-preamble-before-sfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUPCeeRkLwUBBlax@eichest-laptop>
Date: Thu, 18 Dec 2025 09:59:37 +0100
From: Stefan Eichenberger <eichest@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Rob Herring <robh@...nel.org>, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, krzk+dt@...nel.org, conor+dt@...nel.org,
	hkallweit1@...il.com, linux@...linux.org.uk,
	geert+renesas@...der.be, ben.dooks@...ethink.co.uk,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, francesco.dolcini@...adex.com,
	rafael.beims@...adex.com,
	Stefan Eichenberger <stefan.eichenberger@...adex.com>
Subject: Re: [PATCH net-next v1 2/3] dt-bindings: net: micrel: Add
 keep-preamble-before-sfd

Hi Andrew,

On Wed, Dec 17, 2025 at 06:04:56PM +0100, Andrew Lunn wrote:
> > > I think the ideal implementation would be the MAC driver calling some 
> > > phy API to apply the quirk, and then that gets passed on to the phy 
> > > driver. Surely this isn't the first case of a MAC-PHY combination 
> > > needing to go fiddle with some special setting.
> > 
> > I was also hoping to find something like that, but I couldn't really
> > find it. However, I will try looking in that direction. At least we can
> > identify the broken MAC via the compatible string of the MAC driver, as
> > they use two different compatibles: 'fsl,imx8mp-fec' (fine) and
> > 'nxp,imx8mp-dwmac-eqos' (affected by the errata).
> 
> Maybe see if you can use phy_register_fixup_for_id().

That sounds really promising. Thanks a lot for the tip! I'll try to
address our problem by registering a fixup.

Regards,
Stefan