linux-kernel - Re: [PATCH v1 2/5] dt-bindings: firmware: svc: add hwmon property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <721e3771-bcd5-4b38-a183-a5e6966d0b78@altera.com>
Date: Thu, 18 Dec 2025 09:57:18 +0000
From: "Mohamad Jamian, Muhammad Amirul Asyraf"
	<muhammad.amirul.asyraf.mohamad.jamian@...era.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "Mohamad Jamian, Muhammad Amirul
 Asyraf" <muhammad.amirul.asyraf.mohamad.jamian@...era.com>
CC: Guenter Roeck <linux@...ck-us.net>, "linux-hwmon@...r.kernel.org"
	<linux-hwmon@...r.kernel.org>, Dinh Nguyen <dinguyen@...nel.org>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Ang, Tien Sung" <tien.sung.ang@...era.com>,
	"Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>
Subject: Re: [PATCH v1 2/5] dt-bindings: firmware: svc: add hwmon property

On 18/12/2025 4:26 pm, Krzysztof Kozlowski wrote:
> On Mon, Dec 15, 2025 at 10:49:23PM -0800, muhammadamirulasyraf.mohamadjamian@...era.com wrote:
>> From: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@...era.com>
>>
>> Altera SoCFPGA support hardware monitor feature through mailbox. Hence,
>> hwmon property has to be added to the DT to enable the feature beside the
>> hwmon bindings and driver.
>>
>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
>> Signed-off-by: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@...era.com>
>> ---
>>   .../devicetree/bindings/firmware/intel,stratix10-svc.yaml     | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
>> index b42cfa78b28b..4767904c7b76 100644
>> --- a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
>> @@ -62,6 +62,10 @@ properties:
>>       $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
>>       description: Optional child node for fpga manager to perform fabric configuration.
>>   
>> +  hwmon:
>> +    $ref: /schemas/hwmon/altr,socfpga-hwmon.yaml
> 
> This cannot be applied alone and you did not describe merging
> dependencies anywhere.
> 
> Squash the patches or be explicit how this must be merged.
> 
> Other patches from Altera have exactly the same problem, so you keep
> repeating the same.
> 
> 
> Best regards,
> Krzysztof
> 
Will squash this with PATCH 1/5 for adding dt-binding.