linux-kernel - Re: [PATCH net v2] net: bridge: Describe @tunnel_hash member in net_bridge_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1688676b-9252-47b9-97b7-c9dc28d7ac8c@blackwall.org>
Date: Thu, 18 Dec 2025 12:47:51 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Bagas Sanjaya <bagasdotme@...il.com>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Networking <netdev@...r.kernel.org>, bridge@...ts.linux.dev
Cc: Ido Schimmel <idosch@...dia.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Roopa Prabhu <roopa@...ulusnetworks.com>
Subject: Re: [PATCH net v2] net: bridge: Describe @tunnel_hash member in
 net_bridge_vlan_group struct

On 18/12/2025 06:29, Bagas Sanjaya wrote:
> Sphinx reports kernel-doc warning:
> 
> WARNING: ./net/bridge/br_private.h:267 struct member 'tunnel_hash' not described in 'net_bridge_vlan_group'
> 
> Fix it by describing @tunnel_hash member.
> 
> Fixes: efa5356b0d9753 ("bridge: per vlan dst_metadata netlink support")
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
> ---
> This patch is split from assorted kernel-doc fixes series [1].
> 
> Changes since v1 [2]:
> 
>    - Apply wording suggestion (Ido)
> 
> [1]: https://lore.kernel.org/netdev/20251215113903.46555-1-bagasdotme@gmail.com/
> [2]: https://lore.kernel.org/netdev/20251215113903.46555-15-bagasdotme@gmail.com/
> 
>   net/bridge/br_private.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 7280c4e9305f36..b9b2981c484149 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -247,6 +247,7 @@ struct net_bridge_vlan {
>    * struct net_bridge_vlan_group
>    *
>    * @vlan_hash: VLAN entry rhashtable
> + * @tunnel_hash: Hash table to map from tunnel key ID (e.g. VXLAN VNI) to VLAN
>    * @vlan_list: sorted VLAN entry list
>    * @num_vlans: number of total VLAN entries
>    * @pvid: PVID VLAN id
> 
> base-commit: 885bebac9909994050bbbeed0829c727e42bd1b7

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>