linux-kernel - Re: [PATCH can] can: fix build dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251218-giraffe-of-angelic-whirlwind-a6b6f5-mkl@pengutronix.de>
Date: Thu, 18 Dec 2025 13:32:14 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Vincent Mailhol <mailhol@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, 
	Oliver Hartkopp <socketcan@...tkopp.net>, kernel@...gutronix.de, linux-can@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH can] can: fix build dependency

On 17.12.2025 23:24:05, Vincent Mailhol wrote:
> On 17/12/2025 at 10:45, Marc Kleine-Budde wrote:
> > Arnd Bergmann's patch [1] fixed the build dependency problem introduced by
> > bugfix commit cb2dc6d2869a ("can: Kconfig: select CAN driver infrastructure
> > by default"). This ended up as commit 6abd4577bccc ("can: fix build
> > dependency"), but I broke Arnd's fix by removing a dependency that we
> > thought was superfluous.
>
> And my comment subverted you into doing so. I think half of the blame goes to me
> here.

:)

> > [1] https://lore.kernel.org/all/20251204100015.1033688-1-arnd@kernel.org/
> >
> > Meanwhile the problem was also found by intel's kernel test robot,
> > complaining about undefined symbols:
> >
> > | ERROR: modpost: "m_can_class_unregister" [drivers/net/can/m_can/m_can_platform.ko] undefined!
> > | ERROR: modpost: "m_can_class_free_dev" [drivers/net/can/m_can/m_can_platform.ko] undefined!
> > | ERROR: modpost: "m_can_class_allocate_dev" [drivers/net/can/m_can/m_can_platform.ko] undefined!
> > | ERROR: modpost: "m_can_class_get_clocks" [drivers/net/can/m_can/m_can_platform.ko] undefined!
> > | ERROR: modpost: "m_can_class_register" [drivers/net/can/m_can/m_can_platform.ko] undefined!
> >
> > To fix this problem, add the missing dependency again.
> >
> > Cc: Vincent Mailhol <mailhol@...nel.org>
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202512132253.vO9WFDJK-lkp@intel.com/
> > Reported-by: Arnd Bergmann <arnd@...db.de>
> > Closes: https://lore.kernel.org/all/7427949a-ea7d-4854-9fe4-e01db7d878c7@app.fastmail.com/
> > Fixes: 6abd4577bccc ("can: fix build dependency")
> > Fixes: cb2dc6d2869a ("can: Kconfig: select CAN driver infrastructure by default")
> > Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
>
> Acked-by: Vincent Mailhol <mailhol@...nel.org>

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)