linux-kernel - Re: [PATCH v2] arm64: broadcom: bcm2712: Drop rp1 overlay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUQA5IKqqsrElzKP@apocalypse>
Date: Thu, 18 Dec 2025 14:25:56 +0100
From: Andrea della Porta <andrea.porta@...e.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
	bcm-kernel-feedback-list@...adcom.com,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, andrea.porta@...e.com
Subject: Re: [PATCH v2] arm64: broadcom: bcm2712: Drop rp1 overlay

Hi Rob,

On 13:38 Thu 11 Dec     , Rob Herring (Arm) wrote:
> It's a requirement that DT overlays be applied at build time in order to
> validate them as overlays are not validated on their own, but the
> rp1.dtbo is not applied to anything. The rp1.dtso overlay doesn't work
> on its own as there are additional settings needed as seen in
> bcm2712-rpi-5-b.dts. In addition, the 'rp1_nexus' node is applied to the
> wrong place in the DT as it should be under a PCIe root port rather than
> the host bridge. There's also a duplicate overlay in drivers/misc/rp1/.
> 
> For these reasons, just drop the overlay to fix the warning until all
> these issues can be fixed.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
> The missing applying of rp1.dtbo is now a warning in v6.19-rc1. This
> should be sent to Linus ASAP.
> 
> v2:
>  - Drop the overlay instead of trying to rework. The addition of
>    ethernet0 alias complicates that.
> ---
>  arch/arm64/boot/dts/broadcom/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile
> index 83d45afc6588..031875a277d7 100644
> --- a/arch/arm64/boot/dts/broadcom/Makefile
> +++ b/arch/arm64/boot/dts/broadcom/Makefile
> @@ -14,8 +14,7 @@ dtb-$(CONFIG_ARCH_BCM2835) += bcm2711-rpi-400.dtb \
>  			      bcm2837-rpi-3-b.dtb \
>  			      bcm2837-rpi-3-b-plus.dtb \
>  			      bcm2837-rpi-cm3-io3.dtb \
> -			      bcm2837-rpi-zero-2-w.dtb \
> -			      rp1.dtbo
> +			      bcm2837-rpi-zero-2-w.dtb

I'm preparing a rework patch that drops the overlay too, it will fix this warning
and the other concerns about RP1 DT hierarchy. Anyway, since this warning seems
to annoy a lot of people, feel free to apply it in the meantime and I'll adapt
accordingly, hence:

Reviewed-by: Andrea della Porta <andrea.porta@...e.com>

Thanks,
Andrea

>  
>  subdir-y	+= bcmbca
>  subdir-y	+= northstar2
> -- 
> 2.51.0
>