linux-kernel - [PATCH] enclosure: fix a api misuse in enclosure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20251219143343.636091-1-lihaoxiang@isrc.iscas.ac.cn>
Date: Fri, 19 Dec 2025 22:33:43 +0800
From: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
To: arnd@...db.de,
	gregkh@...uxfoundation.org,
	tonyj@...e.de,
	kay.sievers@...y.org
Cc: linux-kernel@...r.kernel.org,
	Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>,
	stable@...r.kernel.org
Subject: [PATCH] enclosure: fix a api misuse in enclosure_register()

If device_register() fails, put_device() is the correct way to
drop the device reference.

Found by code review.

Fixes: ee959b00c335 ("SCSI: convert struct class_device to struct device")
Cc: stable@...r.kernel.org
Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
---
 drivers/misc/enclosure.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c
index ca4c420e4a2f..f7f72856d697 100644
--- a/drivers/misc/enclosure.c
+++ b/drivers/misc/enclosure.c
@@ -149,7 +149,7 @@ enclosure_register(struct device *dev, const char *name, int components,
 
  err:
 	put_device(edev->edev.parent);
-	kfree(edev);
+	put_device(&edev->edev);
 	return ERR_PTR(err);
 }
 EXPORT_SYMBOL_GPL(enclosure_register);
-- 
2.25.1