linux-kernel - Re: [PATCH] arm64: dts: xilinx: Drop "label" property on dlg,slg7xl45106

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqLYz8ZyCGGB_NjyrPdq0P-wjeSfwWPxu1kqCo0qbYFgbQ@mail.gmail.com>
Date: Fri, 19 Dec 2025 08:48:46 -0600
From: Rob Herring <robh@...nel.org>
To: Michal Simek <michal.simek@....com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: xilinx: Drop "label" property on dlg,slg7xl45106

On Thu, Dec 18, 2025 at 8:15 AM Michal Simek <michal.simek@....com> wrote:
>
>
>
> On 12/17/25 21:41, Rob Herring wrote:
> > On Wed, Dec 17, 2025 at 6:39 AM Michal Simek <michal.simek@....com> wrote:
> >> On 12/16/25 18:59, Rob Herring (Arm) wrote:
> >>> The "label" property is not documented for the dlg,slg7xl45106. Nor is
> >>> it common to use for GPIO controllers. So drop it.
> >>>
> >>
> >> Correct it is not documented but it is at least used in Linux also by
> >> drivers/gpio/gpio-mmio.c:810:   err = device_property_read_string(dev, "label",
> >> &label);
> >>
> >> which is also not documented in DT binding.
> >
> > It really should be for all GPIO providers or none of them. IMO, it
> > should be none of them as we already have "gpio-line-names" which is
> > essentially per line labels. I can't see why anyone should care about
> > a label for the controller.
> >
> >> I don't have a problem with it because I can't see it used anywhere.
> >>
> >> But there are other devices where label is the part of binding. And IMHO this
> >> should be more generic property.
> >
> > "label" is the generic property. Not sure what you are suggesting here.
>
> That schema should allow to define label in every node or some class of devices.

I don't care to enable it everywhere. It's allowed in some classes
where the use of it is well defined. I don't think a GPIO provider is
one of those cases.

Rob