linux-kernel - Re: [PATCH RESEND] drm: xe: Replace sprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUVwEvQxNSRf18Qf@intel.com>
Date: Fri, 19 Dec 2025 10:32:34 -0500
From: Rodrigo Vivi <rodrigo.vivi@...el.com>
To: Madhur Kumar <madhurkumar004@...il.com>
CC: <lucas.demarchi@...el.com>, <thomas.hellstrom@...ux.intel.com>,
	<airlied@...il.com>, <simona@...ll.ch>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] drm: xe: Replace sprintf() with sysfs_emit()

On Sun, Dec 14, 2025 at 02:06:59PM +0530, Madhur Kumar wrote:
> Replace sprintf() calls with sysfs_emit() to follow current kernel
> coding standards.
> 
> sysfs_emit() is the preferred method for formatting sysfs output as it
> provides better bounds checking and is more secure.
> 
> Signed-off-by: Madhur Kumar <madhurkumar004@...il.com>

Thanks for the patch.
I just did a small adjustment in the patch subject while getting it
pushed to drm-xe-next.

[drm-xe-next af90706f0eec] drm/xe/pmu: Replace sprintf() with sysfs_emit()

> ---
>  drivers/gpu/drm/xe/xe_pmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pmu.c b/drivers/gpu/drm/xe/xe_pmu.c
> index cab51d826345..f016459c9904 100644
> --- a/drivers/gpu/drm/xe/xe_pmu.c
> +++ b/drivers/gpu/drm/xe/xe_pmu.c
> @@ -425,7 +425,7 @@ static ssize_t event_attr_show(struct device *dev,
>  	struct perf_pmu_events_attr *pmu_attr =
>  		container_of(attr, struct perf_pmu_events_attr, attr);
>  
> -	return sprintf(buf, "event=%#04llx\n", pmu_attr->id);
> +	return sysfs_emit(buf, "event=%#04llx\n", pmu_attr->id);
>  }
>  
>  #define XE_EVENT_ATTR(name_, v_, id_)					\
> -- 
> 2.52.0
>