linux-kernel - Re: [PATCH v3] phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5BojiZe=KdNAtgc0iVhGENdbd4s-PKk8RPGo31KBkOnLw@mail.gmail.com>
Date: Fri, 19 Dec 2025 13:12:23 -0300
From: Fabio Estevam <festevam@...il.com>
To: Stefano Radaelli <stefano.radaelli21@...il.com>
Cc: vkoul@...nel.org, neil.armstrong@...aro.org, shawnguo@...nel.org, 
	s.hauer@...gutronix.de, kernel@...gutronix.de, j.zink@...gutronix.de, 
	linux-kernel@...r.kernel.org, xu.yang_2@....com, jun.li@....com, 
	Frank.Li@....com, haibo.chen@....com, linux-phy@...ts.infradead.org, 
	imx@...ts.linux.dev, Stefano Radaelli <stefano.r@...iscite.com>, 
	Leonid Segal <leonids@...iscite.com>, Pierluigi Passaro <pierluigi.p@...iscite.com>
Subject: Re: [PATCH v3] phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING_FULL field
 before using it

On Fri, Dec 19, 2025 at 1:09 PM Stefano Radaelli
<stefano.radaelli21@...il.com> wrote:
>
> Clear the PCS_TX_SWING_FULL field mask before setting the new value
> in PHY_CTRL5 register. Without clearing the mask first, the OR operation
> could leave previously set bits, resulting in incorrect register
> configuration.
>
> Fixes: 63c85ad0cd81 ("phy: fsl-imx8mp-usb: add support for phy tuning")
> Suggested-by: Leonid Segal <leonids@...iscite.com>
> Acked-by: Pierluigi Passaro <pierluigi.p@...iscite.com>
> Signed-off-by: Stefano Radaelli <stefano.r@...iscite.com>
> Reviewed-by: Xu Yang <xu.yang_2@....com>
> Reviewed-by: Frank Li <Frank.Li@....com>

Reviewed-by: Fabio Estevam <festevam@...il.com>