linux-kernel - Re: [PATCH 3/3] module: Add compile-time check for embedded NUL characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUV7kyjxlijuy5sC@agluck-desk3>
Date: Fri, 19 Dec 2025 08:21:39 -0800
From: "Luck, Tony" <tony.luck@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Al Viro
	<viro@...iv.linux.org.uk>
CC: Daniel Gomez <da.gomez@...nel.org>, Sami Tolvanen
	<samitolvanen@...gle.com>, Chris Li <sparse@...isli.org>, Eric Biggers
	<ebiggers@...nel.org>, Kees Cook <kees@...nel.org>, Luis Chamberlain
	<mcgrof@...nel.org>, Rusty Russell <rusty@...tcorp.com.au>, Petr Pavlu
	<petr.pavlu@...e.com>, "linux-modules@...r.kernel.org"
	<linux-modules@...r.kernel.org>, Malcolm Priestley <tvboxspy@...il.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil
	<hverkuil@...nel.org>, Uwe Kleine-König
	<u.kleine-koenig@...gutronix.de>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-hardening@...r.kernel.org"
	<linux-hardening@...r.kernel.org>
Subject: Re: [PATCH 3/3] module: Add compile-time check for embedded NUL
 characters

On Fri, Dec 19, 2025 at 03:45:42PM +0300, Dan Carpenter wrote:
> On Fri, Dec 12, 2025 at 02:30:48AM +0900, Daniel Gomez wrote:
> > Maybe the flag fix just needs to be applied to the evaluation? Other op
> > structs do the same. But Dan's patch did not implement evaluate. E.g.:
> > 
> > static struct symbol_op constant_p_op = {
> > 	.evaluate = evaluate_to_int_const_expr,
> > 	.expand = expand_constant_p
> > };
> > 
> 
> I was waiting for you to send this as a patch.  I can do it if you
> need me to.

Dan,

Al Viro thought this was wrong. His alternative patch is here:

https://git.kernel.org/pub/scm/linux/kernel/git/viro/sparse.git/commit/?id=2634e39bf02697a18fece057208150362c985992

-Tony