linux-kernel - Re: [PATCH v4 0/6] Microsoft Surface Pro 11 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <176616243275.3584198.6534106165888918555.robh@kernel.org>
Date: Fri, 19 Dec 2025 10:49:06 -0600
From: Rob Herring <robh@...nel.org>
To: Jérôme de Bretagne <jerome.debretagne@...il.com>
Cc: Johannes Berg <johannes@...solutions.net>, 
 Konrad Dybcio <konradybcio@...nel.org>, Dale Whinham <daleyo@...il.com>, 
 linux-arm-msm@...r.kernel.org, 
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
 Hans de Goede <hansg@...nel.org>, platform-driver-x86@...r.kernel.org, 
 devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, 
 ath12k@...ts.infradead.org, Maximilian Luz <luzmaximilian@...il.com>, 
 linux-wireless@...r.kernel.org, Lorenzo Bianconi <lorenzo@...nel.org>, 
 Jeff Johnson <jjohnson@...nel.org>, linux-kernel@...r.kernel.org, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Bjorn Andersson <andersson@...nel.org>, 
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: Re: [PATCH v4 0/6] Microsoft Surface Pro 11 support


On Thu, 18 Dec 2025 23:22:06 +0100, Jérôme de Bretagne wrote:
> This series brings support for the Qualcomm-based Microsoft Surface
> Pro 11 covering both the OLED and LCD variants.
> 
> Signed-off-by: Dale Whinham <daleyo@...il.com>
> Signed-off-by: Jérôme de Bretagne <jerome.debretagne@...il.com>
> ---
> Changes in v4:
> - Re-order the denali entry in the aggregator_registry acpi_match table [Dmitry]
> - Improve the bindings by splitting the LCD and OLED variants into 2 entries [Konrad]
> - Enable i2c4 to make it accessible through i2c-tools [Konrad]
> - Document the addresses for i2c0 and i2c4 like in romulus.dtsi [Konrad]
> - Fix the clock-frequency for i2c0 based on DSDT/SSDT
> - Drop i2c5 which is not found in the DSDT after double-checking
> - Add the R-b: tag from Konrad for the SP11 device trees
> - Link to v3: https://lore.kernel.org/r/20251218-surface-sp11-for-next-v3-0-875afc7bd3b7@gmail.com
> 
> Changes in v3:
> - Update the compatible strings to document both the OLED and LCD variants
> - Move the disable-rfkill property into ieee80211.yaml [Rob,Krzysztof]
> - Reference commit c6a7c0b09d5f and detail the disable-rfkill patch description [Rob,Krzysztof]
> - Switch to the renamed hamoa.dtsi and hamoa-pmics.dtsi [Dale]
> - Improve the comments describing the 2 USB Type-C port location
> - Update the speaker definition to describe only 2-speakers [Konrad]
> - Drop output-low from the speaker definition [Konrad]
> - Enable i2c0 to make it accessible through i2c-tools [Konrad]
> - Delete a non-applicable comment about removable WLAN card [Konrad]
> - Re-order a few nodes and fix indentation issues [Konrad]
> - Squash one of the patches as suggested [Krzysztof]
> - Drop the NAKed patch patch about a dpcd link rate quirk [Dmitry]
> - Include the Reviewed-by: tags
> - Link to v2: https://lore.kernel.org/all/20251201011457.17422-1-daleyo@gmail.com/
> 
> Changes in v2:
>   - Dropped ATNA30DW01 patch as it was merged.
>   - Split device tree into x1e (OLED)/x1p (LCD) specific *.dts files and move common code into x1-microsoft-denali.dtsi (patch 4).
>   - Device tree now enables higher external monitor refresh rates/resolutions (patch 4).
>   - Device tree now enables partially working audio output; requires alsa-ucm-conf and audioreach-topology definitions in userspace (patch 4).
>   - Replaced 'Work around bogus maximum link rate' with a quirk-based approach (patch 5).
>   - Improve the commit message about the disable-rfkill property in response to feedback (patch 6).
> 
> ---
> Dale Whinham (4):
>       firmware: qcom: scm: allow QSEECOM on Surface Pro 11
>       platform/surface: aggregator_registry: Add Surface Pro 11 (QCOM)
>       arm64: dts: qcom: Add support for Surface Pro 11
>       wifi: ath12k: Add support for disabling rfkill via devicetree
> 
> Jérôme de Bretagne (2):
>       dt-bindings: arm: qcom: Document Microsoft Surface Pro 11
>       dt-bindings: wireless: ieee80211: Add disable-rfkill property
> 
>  Documentation/devicetree/bindings/arm/qcom.yaml    |   11 +
>  .../bindings/net/wireless/ieee80211.yaml           |    6 +
>  arch/arm64/boot/dts/qcom/Makefile                  |    4 +
>  arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi  | 1324 ++++++++++++++++++++
>  .../dts/qcom/x1e80100-microsoft-denali-oled.dts    |   20 +
>  .../boot/dts/qcom/x1p64100-microsoft-denali.dts    |   16 +
>  drivers/firmware/qcom/qcom_scm.c                   |    1 +
>  drivers/net/wireless/ath/ath12k/core.c             |    3 +
>  .../platform/surface/surface_aggregator_registry.c |   18 +
>  9 files changed, 1403 insertions(+)
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251218-surface-sp11-for-next-626e327f7b33
> 
> Best regards,
> --
> Jérôme de Bretagne <jerome.debretagne@...il.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251218-surface-sp11-for-next-v4-0-7bcf83c1504a@...il.com:

arch/arm64/boot/dts/qcom/x1e80100-microsoft-denali-oled.dtb: wifi@0 (pci17cb,1107): 'disable-rfkill' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath12k.yaml
arch/arm64/boot/dts/qcom/x1p64100-microsoft-denali.dtb: wifi@0 (pci17cb,1107): 'disable-rfkill' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath12k.yaml