linux-kernel - Re: [PATCH v4 1/6] dt-bindings: arm: qcom: Document Microsoft Surface Pro 11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe4148ec-9dbd-4418-9c36-f4a0b9fd2c24@kernel.org>
Date: Fri, 19 Dec 2025 18:44:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: jerome.debretagne@...il.com, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Johannes Berg <johannes@...solutions.net>,
 Lorenzo Bianconi <lorenzo@...nel.org>,
 Maximilian Luz <luzmaximilian@...il.com>, Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Jeff Johnson <jjohnson@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
 platform-driver-x86@...r.kernel.org, ath12k@...ts.infradead.org,
 Dale Whinham <daleyo@...il.com>
Subject: Re: [PATCH v4 1/6] dt-bindings: arm: qcom: Document Microsoft Surface
 Pro 11

On 19/12/2025 18:40, Krzysztof Kozlowski wrote:
> On 18/12/2025 23:22, Jérôme de Bretagne via B4 Relay wrote:
>> From: Jérôme de Bretagne <jerome.debretagne@...il.com>
>>
>> Add the compatibles for the Qualcomm-based Microsoft Surface Pro 11,
>> using its Denali codename.
>>
>> The LCD models are using the Qualcomm Snapdragon X1 Plus (X1P64100),
>> the OLED ones are using the Qualcomm Snapdragon X1 Elite (X1E80100).
>>
>> Due to the difference in how the built-in panel is being handled
>> between the OLED variant and LCD one, it is required to have two
>> separate DTBs, so document the compatible string for both variants.
>>
>> Signed-off-by: Jérôme de Bretagne <jerome.debretagne@...il.com>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index d84bd3bca2010508a8225b9549d8c634efa06531..3685330344c0bf621125fc3d2f9c04082d6de144 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -1067,6 +1067,17 @@ properties:
>>            - const: qcom,x1e78100
>>            - const: qcom,x1e80100
>>  
>> +      - items:
>> +          - const: microsoft,denali-lcd
>> +          - const: microsoft,denali
>> +          - const: qcom,x1p64100
> 
> 64 < 78, so this should be placed after devkit list.

No, I missed this is x1p, not x1e. This is placed correct, but the oled
should be moved as I suggested.

> 
>> +          - const: qcom,x1e80100
>> +
>> +      - items:
>> +          - const: microsoft,denali-oled
>> +          - const: microsoft,denali
> 
> So this goes after hamoa list, to keep somehow logical order.
> 
>> +          - const: qcom,x1e80100
>> +
>>        - items:
>>            - enum:
>>                - asus,vivobook-s15
>>
> 
> 
> Best regards,
> Krzysztof


Best regards,
Krzysztof