linux-kernel - Re: [PATCH 1/2] dt-bindings: mux: adg1736: add support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ba1d58f-6c54-4727-9152-152de70e5ffb@kernel.org>
Date: Fri, 19 Dec 2025 18:52:20 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>,
 Peter Rosin <peda@...ntia.se>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mux: adg1736: add support

On 19/12/2025 15:35, Antoniu Miclaus wrote:
> Add device tree bindings for ADG1736 analog multiplerer.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> ---
>  .../devicetree/bindings/mux/adi,adg1736.yaml  | 77 +++++++++++++++++++
>  1 file changed, 77 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mux/adi,adg1736.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mux/adi,adg1736.yaml b/Documentation/devicetree/bindings/mux/adi,adg1736.yaml
> new file mode 100644
> index 000000000000..0ba662ffc9cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mux/adi,adg1736.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mux/adi,adg1736.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADG1736 Dual SPDT Switch Multiplexer
> +
> +maintainers:
> +  - Antoniu Miclaus <antoniu.miclaus@...log.com>
> +
> +description: |
> +  Bindings for Analog Devices ADG1736 dual single-pole, double-throw (SPDT)

Describe hardware, not bindings.

> +  switch. The device features two independent SPDT switches, each functioning
> +  as a 2:1 multiplexer. Each switch can connect its common drain terminal (D)
> +  to one of two source terminals (SA or SB).
> +
> +  The device has two independent mux controllers (mux 0 and mux 1), each with
> +  two states:
> +    * 0: SxB to Dx (control GPIO low)
> +    * 1: SxA to Dx (control GPIO high)
> +
> +  The EN pin is shared between both switches and can disable all channels when
> +  set low (inactive).
> +
> +allOf:
> +  - $ref: mux-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: adi,adg1736
> +
> +  ctrl-gpios:
> +    description: |

Do not need '|' unless you need to preserve formatting.

> +      GPIO pins connected to the control inputs IN1 and IN2. Index 0 controls
> +      switch 1 (S1A/S1B to D1) and index 1 controls switch 2 (S2A/S2B to D2).

So just list the items with description.

This is basically gpio-mux with enable pin, so use at least matching
naming - mux-gpios.


> +    minItems: 2
> +    maxItems: 2

And drop these.

> +
> +  en-gpios:

Use standard gpios, see gpio-consumer-common schema.


> +    description: |
> +      GPIO connected to the EN (enable) pin. When low, all switches are
> +      disabled (high-impedance). When high, switches are controlled by
> +      their respective ctrl-gpios.

So just active high?

> +    maxItems: 1
> +
> +  '#mux-control-cells':
> +    const: 1
> +    description: |
> +      Mux controller index (0 or 1) to select which SPDT switch to control.
> +
> +required:
> +  - compatible
> +  - ctrl-gpios
> +  - en-gpios
> +  - '#mux-control-cells'
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/mux/mux.h>
Best regards,
Krzysztof