linux-kernel - Re: [PATCH 14/23] resource: Mark res given to resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d122e9cc-74bf-e233-824e-3aa4f2c7e199@linux.intel.com>
Date: Fri, 19 Dec 2025 19:47:40 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Dan Williams <dan.j.williams@...el.com>, 
    Jonathan Cameron <jonathan.cameron@...wei.com>
cc: linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, 
    Dominik Brodowski <linux@...inikbrodowski.net>, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 14/23] resource: Mark res given to resource_assigned()
 as const

On Fri, 19 Dec 2025, Ilpo Järvinen wrote:

> The caller may hold a const struct resource which will trigger an
> unnecessary warning when calling resource_assigned() as it will not
> modify res in anyway.
> 
> Mark resource_assigned()'s struct resource *res parameter const to
> avoid the compiler warning.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

An afterthought right after sending, I should have Cc'ed Dan & Jonathan 
to this so adding them now.

-- 
 i.


> ---
>  include/linux/ioport.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index 9afa30f9346f..60ca6a49839c 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -338,7 +338,7 @@ static inline bool resource_union(const struct resource *r1, const struct resour
>   * Check if this resource is added to a resource tree or detached. Caller is
>   * responsible for not racing assignment.
>   */
> -static inline bool resource_assigned(struct resource *res)
> +static inline bool resource_assigned(const struct resource *res)
>  {
>  	return res->parent;
>  }
>