linux-kernel - RE: [PATCH] crypto: iaa - Replace sprintf with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ2PR11MB8472C7611888CAB6F21C8CE1C9A9A@SJ2PR11MB8472.namprd11.prod.outlook.com>
Date: Fri, 19 Dec 2025 19:00:42 +0000
From: "Sridhar, Kanchana P" <kanchana.p.sridhar@...el.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>, "Accardi, Kristen C"
	<kristen.c.accardi@...el.com>, "Gomes, Vinicius" <vinicius.gomes@...el.com>,
	Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller"
	<davem@...emloft.net>
CC: "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Sridhar,
 Kanchana P" <kanchana.p.sridhar@...el.com>
Subject: RE: [PATCH] crypto: iaa - Replace sprintf with sysfs_emit in sysfs
 show functions


> -----Original Message-----
> From: Thorsten Blum <thorsten.blum@...ux.dev>
> Sent: Sunday, December 14, 2025 11:24 PM
> To: Accardi, Kristen C <kristen.c.accardi@...el.com>; Gomes, Vinicius
> <vinicius.gomes@...el.com>; Sridhar, Kanchana P
> <kanchana.p.sridhar@...el.com>; Herbert Xu
> <herbert@...dor.apana.org.au>; David S. Miller <davem@...emloft.net>
> Cc: Thorsten Blum <thorsten.blum@...ux.dev>; linux-crypto@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Subject: [PATCH] crypto: iaa - Replace sprintf with sysfs_emit in sysfs show
> functions
> 
> Replace sprintf() with sysfs_emit() in verify_compress_show() and
> sync_mode_show(). sysfs_emit() is preferred to format sysfs output as it
> provides better bounds checking.  No functional changes.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Acked-by: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>

> ---
>  drivers/crypto/intel/iaa/iaa_crypto_main.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> index d0058757b000..9e2a17c473ef 100644
> --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> @@ -5,6 +5,7 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/pci.h>
> +#include <linux/sysfs.h>
>  #include <linux/device.h>
>  #include <linux/iommu.h>
>  #include <uapi/linux/idxd.h>
> @@ -96,7 +97,7 @@ static bool iaa_verify_compress = true;
> 
>  static ssize_t verify_compress_show(struct device_driver *driver, char *buf)
>  {
> -	return sprintf(buf, "%d\n", iaa_verify_compress);
> +	return sysfs_emit(buf, "%d\n", iaa_verify_compress);
>  }
> 
>  static ssize_t verify_compress_store(struct device_driver *driver,
> @@ -188,11 +189,11 @@ static ssize_t sync_mode_show(struct
> device_driver *driver, char *buf)
>  	int ret = 0;
> 
>  	if (!async_mode && !use_irq)
> -		ret = sprintf(buf, "%s\n", "sync");
> +		ret = sysfs_emit(buf, "%s\n", "sync");
>  	else if (async_mode && !use_irq)
> -		ret = sprintf(buf, "%s\n", "async");
> +		ret = sysfs_emit(buf, "%s\n", "async");
>  	else if (async_mode && use_irq)
> -		ret = sprintf(buf, "%s\n", "async_irq");
> +		ret = sysfs_emit(buf, "%s\n", "async_irq");
> 
>  	return ret;
>  }
> --
> Thorsten Blum <thorsten.blum@...ux.dev>
> GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4