linux-kernel - Re: [PATCH 2/4] soc: qcom: apr: Use typedef for GPR callback member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7rk2zdwyznc7ljiqkylmmqlakmo3c4k3r3hhlbq2j6ojujusy7@iwg6qj7smvkk>
Date: Fri, 19 Dec 2025 12:43:37 -0800
From: Bjorn Andersson <andersson@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>, 
	Srinivas Kandagatla <srini@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, 
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 2/4] soc: qcom: apr: Use typedef for GPR callback member

On Sun, Nov 30, 2025 at 10:40:24AM +0100, Krzysztof Kozlowski wrote:
> There is already a typedef for GPR callback used in 'struct
> pkt_router_svc', so use it also in 'struct apr_driver', because it is
> the same type - one is assigned to another in apr_device_probe().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Acked-by: Bjorn Andersson <andersson@...nel.org>

Regards,
Bjorn

> ---
>  include/linux/soc/qcom/apr.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/soc/qcom/apr.h b/include/linux/soc/qcom/apr.h
> index 35f44cd868cb..b16530f319ad 100644
> --- a/include/linux/soc/qcom/apr.h
> +++ b/include/linux/soc/qcom/apr.h
> @@ -156,7 +156,7 @@ struct apr_driver {
>  	void	(*remove)(struct apr_device *sl);
>  	int	(*callback)(struct apr_device *a,
>  			    const struct apr_resp_pkt *d);
> -	int	(*gpr_callback)(struct gpr_resp_pkt *d, void *data, int op);
> +	gpr_port_cb gpr_callback;
>  	struct device_driver		driver;
>  	const struct apr_device_id	*id_table;
>  };
> 
> -- 
> 2.48.1
>