linux-kernel - Re: [PATCH 1/1] software node: Also support referencing non-constant software nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48b94c22-c1ca-4220-b184-f38e22544b9d@panix.com>
Date: Fri, 19 Dec 2025 12:55:30 -0800
From: Kenneth Crudup <kenny@...ix.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-kernel@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Danilo Krummrich <dakr@...nel.org>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Daniel Scally <djrscally@...il.com>,
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Linus Walleij <linus.walleij@...aro.org>,
 Philipp Zabel <p.zabel@...gutronix.de>,
 Charles Keepax <ckeepax@...nsource.cirrus.com>, linux-acpi@...r.kernel.org,
 linux-media@...r.kernel.org, johannes.goede@....qualcomm.com,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 1/1] software node: Also support referencing non-constant
 software nodes

Apparently last to the party :) but:

Tested-By: Kenneth R. Crudup <kenny@...ix.com>

-K

On 12/19/25 00:36, Sakari Ailus wrote:
> Fwnode references are be implemented differently if referenced node is a
> software node. _Generic() is used to differentiate between the two cases
> but only const software nodes were present in the selection. Also add
> non-const software nodes.
> 
> Reported-by: Kenneth Crudup <kenny@...ix.com>
> Closes: https://lore.kernel.org/all/af773b82-bef2-4209-baaf-526d4661b7fc@panix.com/
> Fixes: d7cdbbc93c56 ("software node: allow referencing firmware nodes")
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> ---
> Hi Kenneth,
> 
> Many thanks for reporting the issue and bisecting the offending patch!
> Could you confirm whether this fixes the issue (it does for me)?
> 
> - Sakari
> 
>   include/linux/property.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 272bfbdea7bf..e30ef23a9af3 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -371,6 +371,7 @@ struct software_node_ref_args {
>   (const struct software_node_ref_args) {				\
>   	.swnode = _Generic(_ref_,				\
>   			   const struct software_node *: _ref_,	\
> +			   struct software_node *: _ref_,	\
>   			   default: NULL),			\
>   	.fwnode = _Generic(_ref_,				\
>   			   struct fwnode_handle *: _ref_,	\

-- 
Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange 
County CA