linux-kernel - Re: [PATCH v1] ASoC: ops: fix snd_soc_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62f352ef-f89e-49b6-9b51-c6e1c3c4f510@davidgow.net>
Date: Fri, 19 Dec 2025 12:22:49 +0800
From: David Gow <david@...idgow.net>
To: Stefan Binding <sbinding@...nsource.cirrus.com>,
 Mark Brown <broonie@...nel.org>
Cc: Niranjan H Y <niranjan.hy@...com>, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com,
 Charles Keepax <ckeepax@...nsource.cirrus.com>
Subject: Re: [PATCH v1] ASoC: ops: fix snd_soc_get_volsw for sx controls

Le 16/12/2025 à 9:49 PM, Stefan Binding a écrit :
> SX controls are currently broken, since the clamp introduced in
> commit a0ce874cfaaa ("ASoC: ops: improve snd_soc_get_volsw") does not
> handle SX controls, for example where the min value in the clamp is
> greater than the max value in the clamp.
> 
> Add clamp parameter to prevent clamping in SX controls.
> The nature of SX controls mean that it wraps around 0, with a variable
> number of bits, therefore clamping the value becomes complicated and
> prone to error.
> 
> Fixes 35 kunit tests for soc_ops_test_access.
> 
> Fixes: a0ce874cfaaa ("ASoC: ops: improve snd_soc_get_volsw")
> 
> Co-developed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> Signed-off-by: Stefan Binding <sbinding@...nsource.cirrus.com>
> ---

Thanks very much: I've just bisected those failures to the same patch, 
so am definitely keen to see this fixed.

Tested-by: David Gow <david@...idgow.net>

Cheers,
-- David