linux-kernel - Re: [PATCH next] wifi: ath12k: clean up on error in ath12k_dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f113b35e-b84f-40b6-89a7-284018e93853@oss.qualcomm.com>
Date: Fri, 19 Dec 2025 13:42:15 +0800
From: Baochen Qiang <baochen.qiang@....qualcomm.com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
        Harsh Kumar Bijlani <quic_hbijlani@...cinc.com>
Cc: Jeff Johnson <jjohnson@...nel.org>, Ripan Deuri
 <quic_rdeuri@...cinc.com>,
        Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@....qualcomm.com>,
        linux-wireless@...r.kernel.org, ath12k@...ts.infradead.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] wifi: ath12k: clean up on error in ath12k_dp_setup()



On 12/18/2025 3:44 PM, Dan Carpenter wrote:
> Destroy the rhash_tbl before returning the error code.

Would be better if the actual problem can be described first.

> 
> Fixes: a88cf5f71adf ("wifi: ath12k: Add hash table for ath12k_dp_link_peer")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/net/wireless/ath/ath12k/dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c
> index 9f05eea6695a..ab54c8a84d3e 100644
> --- a/drivers/net/wireless/ath/ath12k/dp.c
> +++ b/drivers/net/wireless/ath/ath12k/dp.c
> @@ -1513,7 +1513,7 @@ static int ath12k_dp_setup(struct ath12k_base *ab)
>  					HAL_WBM_IDLE_LINK, srng, n_link_desc);
>  	if (ret) {
>  		ath12k_warn(ab, "failed to setup link desc: %d\n", ret);
> -		return ret;
> +		goto rhash_destroy;
>  	}
>  
>  	ret = ath12k_dp_cc_init(ab);
However since this is trivial ...

Reviewed-by: Baochen Qiang <baochen.qiang@....qualcomm.com>