linux-kernel - Re: [PATCH 1/1] crypto: fips: annotate fips_enable() with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUT5wK9AXAzFvIy3@gondor.apana.org.au>
Date: Fri, 19 Dec 2025 15:07:44 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Can Peng <pengcan@...inos.cn>
Cc: davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] crypto: fips: annotate fips_enable() with __init to
 free init memory after boot

On Mon, Dec 08, 2025 at 05:50:10PM +0800, Can Peng wrote:
> The fips_enable() function is only invoked early during kernel boot via the
> __setup() macro ("fips=" command line parameter), and is never used again
> after initialization completes.
> 
> Annotating it with __init places the function in the .init.text section,
> allowing the kernel to free its memory after init (when freeing_initmem()
> runs), reducing runtime memory footprint.
> 
> This is a standard practice for setup/early-parse functions and has no
> functional impact — the parsing logic, return values, and fips mode
> setting behavior remain unchanged.
> 
> Signed-off-by: Can Peng <pengcan@...inos.cn>
> ---
>  crypto/fips.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt