linux-kernel - Re: [PATCH v2 0/6] i2c: designware: Enable mode swapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251219074312.GX2275908@black.igk.intel.com>
Date: Fri, 19 Dec 2025 08:43:12 +0100
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: Andi Shyti <andi.shyti@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Jan Dabros <jsd@...ihalf.com>, Raag Jadav <raag.jadav@...el.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/6] i2c: designware: Enable mode swapping

On Thu, Dec 18, 2025 at 04:14:59PM +0100, Heikki Krogerus wrote:
> Hi,
> 
> Changed since v1:
> - The init cb is replaced with i2c_dw_init() also in i2c-designware-amdisp.c
> - Checking I2C_FUNC_SLAVE in i2c_dw_reg_slave()
> 
> The original cover letter:
> 
> It's currently not possible to support MCTP or any other protocol that
> requires support for both modes with the DesignWare I2C because the
> driver can only be used in one mode. I'm assuming that the driver was
> designed this way because the DesignWare I2C can not be operated as
> I2C master and I2C slave simultaneously, however, that does not
> actually mean both modes could not be supported at the same time. See
> the patch 5/6 for more detailed explanation.
> 
> This series will enable support for both modes in the driver by
> utilising a simple mode swap method, and that way make it possible to
> support MCTP, IPMI, SMBus Host Notification Protocol, and any other
> protocol requires the support for both modes with the DesignWare I2C.
> 
> thanks,
> 
> Heikki Krogerus (6):
>   i2c: designware: Remove useless driver specific option for I2C target
>   i2c: designware: Remove unnecessary function exports
>   i2c: designware: Combine some of the common functions
>   i2c: designware: Combine the init functions
>   i2c: designware: Enable mode swapping
>   i2c: designware: Remove an unnecessary condition

For the whole series,

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>