linux-kernel - Re: [PATCH bpf-next v6 6/8] lib/Kconfig.debug: Set the minimum required pahole version to v1.22

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUUEyncduBLl8k4n@derry.ads.avm.de>
Date: Fri, 19 Dec 2025 08:54:50 +0100
From: Nicolas Schier <nsc@...nel.org>
To: Ihor Solodrai <ihor.solodrai@...ux.dev>
Cc: Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	John Fastabend <john.fastabend@...il.com>,
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Jonathan Corbet <corbet@....net>, Tejun Heo <tj@...nel.org>,
	David Vernet <void@...ifault.com>, Andrea Righi <arighi@...dia.com>,
	Changwoo Min <changwoo@...lia.com>, Shuah Khan <shuah@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Alan Maguire <alan.maguire@...cle.com>,
	Donglin Peng <dolinux.peng@...il.com>, bpf@...r.kernel.org,
	dwarves@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kbuild@...r.kernel.org, sched-ext@...ts.linux.dev
Subject: Re: [PATCH bpf-next v6 6/8] lib/Kconfig.debug: Set the minimum
 required pahole version to v1.22

On Thu, Dec 18, 2025 at 06:00:04PM -0800, Ihor Solodrai wrote:
> Subsequent patches in the series change vmlinux linking scripts to
> unconditionally pass --btf_encode_detached to pahole, which was
> introduced in v1.22 [1][2].
> 
> This change allows to remove PAHOLE_HAS_SPLIT_BTF Kconfig option and
> other checks of older pahole versions.
> 
> [1] https://github.com/acmel/dwarves/releases/tag/v1.22
> [2] https://lore.kernel.org/bpf/cbafbf4e-9073-4383-8ee6-1353f9e5869c@oracle.com/
> 
> Acked-by: Eduard Zingerman <eddyz87@...il.com>
> Signed-off-by: Ihor Solodrai <ihor.solodrai@...ux.dev>
> ---
>  Documentation/scheduler/sched-ext.rst |  1 -
>  lib/Kconfig.debug                     | 13 ++++---------
>  scripts/Makefile.btf                  |  9 +--------
>  tools/sched_ext/README.md             |  1 -
>  4 files changed, 5 insertions(+), 19 deletions(-)
> 
> diff --git a/Documentation/scheduler/sched-ext.rst b/Documentation/scheduler/sched-ext.rst
> index 404fe6126a76..9e2882d937b4 100644
> --- a/Documentation/scheduler/sched-ext.rst
> +++ b/Documentation/scheduler/sched-ext.rst
> @@ -43,7 +43,6 @@ options should be enabled to use sched_ext:
>      CONFIG_DEBUG_INFO_BTF=y
>      CONFIG_BPF_JIT_ALWAYS_ON=y
>      CONFIG_BPF_JIT_DEFAULT_ON=y
> -    CONFIG_PAHOLE_HAS_SPLIT_BTF=y
>      CONFIG_PAHOLE_HAS_BTF_TAG=y
>  
>  sched_ext is used only when the BPF scheduler is loaded and running.
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index ba36939fda79..60281c4f9e99 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -388,18 +388,13 @@ config DEBUG_INFO_BTF
>  	depends on !DEBUG_INFO_SPLIT && !DEBUG_INFO_REDUCED
>  	depends on !GCC_PLUGIN_RANDSTRUCT || COMPILE_TEST
>  	depends on BPF_SYSCALL
> -	depends on PAHOLE_VERSION >= 116
> -	depends on DEBUG_INFO_DWARF4 || PAHOLE_VERSION >= 121
> +	depends on PAHOLE_VERSION >= 122

As CONFIG_DEBUG_INFO_BTF was the reason for 'pahole' being listed in
Documentation/process/changes.rst, does it make sense to update the
minimum pahole version there, too?

Acked-by: Nicolas Schier <nsc@...nel.org>