linux-kernel - Re: [PATCH v3 0/3] Generalize vmemmap_populate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUUbC4QWMZn_BO8L@kernel.org>
Date: Fri, 19 Dec 2025 11:29:47 +0200
From: Mike Rapoport <rppt@...nel.org>
To: chengkaitao <pilgrimtao@...il.com>
Cc: davem@...emloft.net, andreas@...sler.com, akpm@...ux-foundation.org,
	david@...nel.org, lorenzo.stoakes@...cle.com,
	Liam.Howlett@...cle.com, vbabka@...e.cz, surenb@...gle.com,
	mhocko@...e.com, kevin.brodsky@....com, dave.hansen@...ux.intel.com,
	ziy@...dia.com, chengkaitao@...inos.cn, willy@...radead.org,
	zhengqi.arch@...edance.com, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v3 0/3] Generalize vmemmap_populate_hugepages to sparc

On Fri, Dec 19, 2025 at 01:47:46AM +0800, chengkaitao wrote:
> Sparc implement vmemmap_populate using vmemmap_populate_hugepages
> to streamline the code. Another benefit is that it allows us to

If this is merged via mm tree, the cover letter would be a part of git
history so I'd suggest slightly rephrasing the first sentence:

Change sparc's implementation of vmemmap_populate() using
vmemmap_populate_hugepages() to streamline the code.

> eliminate the external declarations of vmemmap_p?d_populate
> functions and convert them to static functions.
> 
> Since vmemmap_populate_hugepages may fallback to vmemmap_populate-
> _basepages, which differs from sparc's original implementation.
> During the v1 discussion with Mike Rapoport, sparc uses base pages
> in the kernel page tables, so it should be able to use them in
> vmemmap as well. Consequently, no additional special handling is
> required.
> 
> Remove unnecessary whitespace from sparc.
> 
> Changes in v3:
> - Allow sparc to fallback to vmemmap_populate_basepages
> - Convert vmemmap_p?d_populate() to static functions
> - Split the v1 patch
> 
> Changes in v2:
> - Revert the whitespace deletions
> - Change vmemmap_false_pmd to vmemmap_pte_fallback_allowed
> 
> Link to V1:
> https://lore.kernel.org/all/20251217120858.18713-1-pilgrimtao@gmail.com/
> 
> Chengkaitao (3):
>   sparc: Use vmemmap_populate_hugepages for vmemmap_populate
>   mm: Convert vmemmap_p?d_populate() to static functions
>   sparc: Remove unnecessary whitespace
> 
>  arch/sparc/mm/fault_64.c   |  4 +--
>  arch/sparc/mm/hypersparc.S |  4 +--
>  arch/sparc/mm/init_64.c    | 53 ++++++++++++--------------------------
>  arch/sparc/mm/io-unit.c    | 12 ++++-----
>  arch/sparc/mm/iommu.c      |  2 +-
>  arch/sparc/mm/swift.S      |  2 +-
>  arch/sparc/mm/ultra.S      |  4 +--
>  include/linux/mm.h         |  7 -----
>  mm/sparse-vmemmap.c        | 10 +++----
>  9 files changed, 36 insertions(+), 62 deletions(-)
> 
> -- 
> 2.50.1 (Apple Git-155)
> 

-- 
Sincerely yours,
Mike.