linux-kernel - Re: [PATCH] vfio/xe: Add default handler for .get_region_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e199209-6af1-4be2-9f10-5ade001bc3bf@linux.intel.com>
Date: Fri, 19 Dec 2025 10:35:56 +0100
From: "Bernatowicz, Marcin" <marcin.bernatowicz@...ux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@...el.com>,
 intel-xe@...ts.freedesktop.org
Cc: Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>, Jason Gunthorpe <jgg@...dia.com>,
 Kevin Tian <kevin.tian@...el.com>, Alex Williamson <alex@...zbot.org>,
 Michał Winiarski <michal.winiarski@...el.com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 kvm@...r.kernel.org
Subject: Re: [PATCH] vfio/xe: Add default handler for .get_region_info_caps


On 12/18/2025 9:51 PM, Michal Wajdeczko wrote:
> New requirement for the vfio drivers was added by the commit
> f97859503859 ("vfio: Require drivers to implement get_region_info")
> followed by commit 1b0ecb5baf4a ("vfio/pci: Convert all PCI drivers
> to get_region_info_caps") that was missed by the new vfio/xe driver.
>
> Add handler for .get_region_info_caps to avoid -EINVAL errors.
>
> Fixes: 2e38c50ae492 ("vfio/xe: Add device specific vfio_pci driver variant for Intel graphics")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@...el.com>
> ---
> Cc: Thomas Hellström <thomas.hellstrom@...ux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@...el.com>
> Cc: Jason Gunthorpe <jgg@...dia.com>
> Cc: Kevin Tian <kevin.tian@...el.com>
> Cc: Alex Williamson <alex@...zbot.org>
> Cc: Michał Winiarski <michal.winiarski@...el.com>
> Cc: Marcin Bernatowicz <marcin.bernatowicz@...ux.intel.com>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-kernel@...r.kernel.org
> Cc: kvm@...r.kernel.org
> ---
>   drivers/vfio/pci/xe/main.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vfio/pci/xe/main.c b/drivers/vfio/pci/xe/main.c
> index 0156b53c678b..719ab4660085 100644
> --- a/drivers/vfio/pci/xe/main.c
> +++ b/drivers/vfio/pci/xe/main.c
> @@ -504,6 +504,7 @@ static const struct vfio_device_ops xe_vfio_pci_ops = {
>   	.open_device = xe_vfio_pci_open_device,
>   	.close_device = xe_vfio_pci_close_device,
>   	.ioctl = vfio_pci_core_ioctl,
> +	.get_region_info_caps = vfio_pci_ioctl_get_region_info,
>   	.device_feature = vfio_pci_core_ioctl_feature,
>   	.read = vfio_pci_core_read,
>   	.write = vfio_pci_core_write,
Reviewed-by: Marcin Bernatowicz <marcin.bernatowicz@...ux.intel.com>
Tested-by: Marcin Bernatowicz <marcin.bernatowicz@...ux.intel.com>

I tested it on v6.19-rc1 with QEMU 8.2.2
passing through an Intel Xe VF. The patch fixes the -EINVAL failure
on VFIO_DEVICE_GET_REGION_INFO.