linux-kernel - Re: [PATCH] clockevents: add a error handling in tick_broadcast_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xa2bwso.ffs@tglx>
Date: Fri, 19 Dec 2025 11:17:27 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>, anna-maria@...utronix.de,
 frederic@...nel.org
Cc: linux-kernel@...r.kernel.org, Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>,
 stable@...r.kernel.org
Subject: Re: [PATCH] clockevents: add a error handling in
 tick_broadcast_init_sysfs()

On Thu, Dec 18 2025 at 17:06, Haoxiang Li wrote:
> If device_register() fails, call put_device() to drop
> the device reference.
>
> Fixes: 501f867064e9 ("clockevents: Provide sysfs interface")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
> ---
>  kernel/time/clockevents.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
> index a59bc75ab7c5..94e223cf9c74 100644
> --- a/kernel/time/clockevents.c
> +++ b/kernel/time/clockevents.c
> @@ -733,8 +733,12 @@ static __init int tick_broadcast_init_sysfs(void)
>  {
>  	int err = device_register(&tick_bc_dev);
>  
> -	if (!err)
> -		err = device_create_file(&tick_bc_dev, &dev_attr_current_device);
> +	if (err) {
> +		put_deivce(&tick_bc_dev);

My brain compiler tells me that this was not even compiled. Try again.