linux-kernel - Re: [PATCH 6/7] drm/bridge: tc358768: Separate video format config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251219104420.GF39796@francesco-nb>
Date: Fri, 19 Dec 2025 11:44:20 +0100
From: Francesco Dolcini <francesco@...cini.it>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Robert Foss <rfoss@...nel.org>,
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
	Jonas Karlman <jonas@...boo.se>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Parth Pancholi <parth.pancholi@...adex.com>,
	Francesco Dolcini <francesco.dolcini@...adex.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] drm/bridge: tc358768: Separate video format config

On Tue, Oct 21, 2025 at 04:23:02PM +0300, Tomi Valkeinen wrote:
> Sending long commands using the video buffer (to be implemented in
> following patches) requires setting TC358768_DATAFMT and
> TC358768_DSITX_DT registers for command transfer. The same registers
> also need to be configured properly for video transfer.
> 
> The long commands will be sent between the bridge's pre_enable() and
> enable(), and currently we configure the registers for video transfer in
> pre_enable(). Thus, they would be overwritten by the long command
> transfer code.
> 
> To prevent that from happening, set those registers for video transfer
> in enable(), not in pre_enable().
> 
> Based on code from Parth Pancholi <parth.pancholi@...adex.com>
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>

Reviewed-by: Francesco Dolcini <francesco.dolcini@...adex.com>