linux-kernel - Re: [PATCH 1/2] sched/fair: fix comma operator misuse in NUMA fault accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251219105428.GD1132199@noisy.programming.kicks-ass.net>
Date: Fri, 19 Dec 2025 11:54:28 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Zhan Xusheng <zhanxusheng1024@...il.com>
Cc: Ingo Molnar <mingo@...hat.com>, linux-sched@...r.kernel.org,
	linux-kernel@...r.kernel.org, Zhan Xusheng <zhanxusheng@...omi.com>
Subject: Re: [PATCH 1/2] sched/fair: fix comma operator misuse in NUMA fault
 accounting

On Fri, Dec 19, 2025 at 04:50:04PM +0800, Zhan Xusheng wrote:
> Replace the comma operator with separate statements when assigning
> NUMA fault statistics. This improves readability and follows kernel
> coding style.

This is the only one of the lot I would remotely consider applying. The
rest is just noise. Please don't do style patches.

> 
> Signed-off-by: Zhan Xusheng <zhanxusheng@...omi.com>
> ---
>  kernel/sched/fair.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index da46c3164537..56dd655d9bc2 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -13957,7 +13957,7 @@ void show_numa_stats(struct task_struct *p, struct seq_file *m)
>  			tpf = p->numa_faults[task_faults_idx(NUMA_MEM, node, 1)];
>  		}
>  		if (ng) {
> -			gsf = ng->faults[task_faults_idx(NUMA_MEM, node, 0)],
> +			gsf = ng->faults[task_faults_idx(NUMA_MEM, node, 0)];
>  			gpf = ng->faults[task_faults_idx(NUMA_MEM, node, 1)];
>  		}
>  		print_numa_stats(m, node, tsf, tpf, gsf, gpf);
> -- 
> 2.43.0
>