linux-kernel - RE: [PATCH] HID: intel-ish-hid: loader: Add PRODUCT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5613BDF3C10AE8093404639A93A9A@SJ0PR11MB5613.namprd11.prod.outlook.com>
Date: Fri, 19 Dec 2025 01:26:30 +0000
From: "Zhang, Lixu" <lixu.zhang@...el.com>
To: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>, Vishnu Sankar
	<vishnuocv@...il.com>, "jikos@...nel.org" <jikos@...nel.org>,
	"bentiss@...nel.org" <bentiss@...nel.org>, "Sankar, Vishnu"
	<vsankar@...ovo.com>, "Xu, Even" <even.xu@...el.com>
CC: "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Mark Pearson
	<mpearson-lenovo@...ebb.ca>, Richie Roy Jayme <rjayme.jp@...il.com>
Subject: RE: [PATCH] HID: intel-ish-hid: loader: Add PRODUCT_FAMILY-based
 firmware matching

>-----Original Message-----
>From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
>Sent: Thursday, December 18, 2025 11:55 PM
>To: Vishnu Sankar <vishnuocv@...il.com>; jikos@...nel.org;
>bentiss@...nel.org; Sankar, Vishnu <vsankar@...ovo.com>; Zhang, Lixu
><lixu.zhang@...el.com>; Xu, Even <even.xu@...el.com>
>Cc: linux-input@...r.kernel.org; linux-kernel@...r.kernel.org; Mark Pearson
><mpearson-lenovo@...ebb.ca>; Richie Roy Jayme <rjayme.jp@...il.com>
>Subject: Re: [PATCH] HID: intel-ish-hid: loader: Add PRODUCT_FAMILY-based
>firmware matching
>
>+ Lixu
>+ Even
>
>
>On Thu, 2025-12-18 at 23:00 +0900, Vishnu Sankar wrote:
>> Add support for firmware filenames that include the CRC32 checksum of
>> the DMI product_family field. Several OEMs ship ISH firmware variants
>> shared across a product family while product_name or product_sku may
>> differ.
>> This
>> intermediate matching granularity reduces duplication and improves
>> firmware selection for vendor-customized platforms.

...

>> +
>> +	if (sys_vendor && product_family) {
>> +		snprintf(filename, sizeof(filename),
>> +			 ISH_FW_FILE_VENDOR_FAMILY_FMT,
>> +			 gen, vendor_crc, family_crc);
>> +		ret = _request_ish_firmware(firmware_p, filename,
>> dev);
>> +		if (!ret)
>> +			return 0;
>> +}
Indent issue.

Hi Vishnu,
Thanks for your patch.
1. Please run the ` ./scripts/checkpatch.pl --strict --codespell [PATCH FILE]`, and fix the issue.
2. Could you please also update the document `Documentation/hid/intel-ish-hid.rst`?

Thanks,
Lixu

>>
>>  	if (sys_vendor && product_name && product_sku) {
>>  		snprintf(filename, sizeof(filename),
>> ISH_FW_FILE_VENDOR_NAME_SKU_FMT, gen,