linux-kernel - Re: [PATCH 1/4] drm/gpuvm: take GEM lock inside drm_gpuvm_bo_obtain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DF26ONGZ03KH.31FVI22UBGJFX@kernel.org>
Date: Fri, 19 Dec 2025 13:15:04 +0100
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Alice Ryhl" <aliceryhl@...gle.com>
Cc: "Daniel Almeida" <daniel.almeida@...labora.com>, "Matthew Brost"
 <matthew.brost@...el.com>, Thomas Hellström
 <thomas.hellstrom@...ux.intel.com>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, "David Airlie"
 <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Boris Brezillon"
 <boris.brezillon@...labora.com>, "Steven Price" <steven.price@....com>,
 "Liviu Dudau" <liviu.dudau@....com>, "Miguel Ojeda" <ojeda@...nel.org>,
 "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Trevor
 Gross" <tmgross@...ch.edu>, "Frank Binns" <frank.binns@...tec.com>, "Matt
 Coster" <matt.coster@...tec.com>, "Rob Clark"
 <robin.clark@....qualcomm.com>, "Dmitry Baryshkov" <lumag@...nel.org>,
 "Abhinav Kumar" <abhinav.kumar@...ux.dev>, "Jessica Zhang"
 <jessica.zhang@....qualcomm.com>, "Sean Paul" <sean@...rly.run>, "Marijn
 Suijten" <marijn.suijten@...ainline.org>, "Lyude Paul" <lyude@...hat.com>,
 "Lucas De Marchi" <lucas.demarchi@...el.com>, "Rodrigo Vivi"
 <rodrigo.vivi@...el.com>, "Sumit Semwal" <sumit.semwal@...aro.org>,
 Christian König <christian.koenig@....com>,
 <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
 <freedreno@...ts.freedesktop.org>, <nouveau@...ts.freedesktop.org>,
 <intel-xe@...ts.freedesktop.org>, <linux-media@...r.kernel.org>,
 <linaro-mm-sig@...ts.linaro.org>
Subject: Re: [PATCH 1/4] drm/gpuvm: take GEM lock inside
 drm_gpuvm_bo_obtain_prealloc()

On Fri Nov 28, 2025 at 3:14 PM CET, Alice Ryhl wrote:
> +static void
> +drm_gpuvm_bo_destroy_not_in_lists(struct drm_gpuvm_bo *vm_bo)
> +{
> +	struct drm_gpuvm *gpuvm = vm_bo->vm;
> +	const struct drm_gpuvm_ops *ops = gpuvm->ops;
> +	struct drm_gem_object *obj = vm_bo->obj;
> +
> +	if (ops && ops->vm_bo_free)
> +		ops->vm_bo_free(vm_bo);
> +	else
> +		kfree(vm_bo);
> +
> +	drm_gpuvm_put(gpuvm);
> +	drm_gem_object_put(obj);
> +}

I think to us it seems obvious, but I think for new people it might not be. Can
you please add a comment that mentions that this is about the evict and extobj
lists and explains how this is related to locking?