linux-kernel - Re: [PATCH v1 3/4] wifi: rsi: sdio: Migrate to use sdio specific shutdown function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFoQVh=WhB0AFFcwX-yeGM5s5cEFTUUS4LXnAcTEnikF2g@mail.gmail.com>
Date: Fri, 19 Dec 2025 13:24:06 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: linux-mmc@...r.kernel.org, linux-wireless@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/4] wifi: rsi: sdio: Migrate to use sdio specific
 shutdown function

On Wed, 17 Dec 2025 at 12:09, Uwe Kleine-König
<u.kleine-koenig@...libre.com> wrote:
>
> This saves a cast in the driver. The motivation is stop using the callback
> .shutdown in rsi_driver.drv to make it possible to drop that.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
>  drivers/net/wireless/rsi/rsi_91x_sdio.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c
> index c2b2d09b616f..a1376847ac85 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c
> @@ -1442,9 +1442,8 @@ static int rsi_thaw(struct device *dev)
>         return 0;
>  }
>
> -static void rsi_shutdown(struct device *dev)
> +static void rsi_shutdown(struct sdio_func *pfunction)
>  {
> -       struct sdio_func *pfunction = dev_to_sdio_func(dev);
>         struct rsi_hw *adapter = sdio_get_drvdata(pfunction);
>         struct rsi_91x_sdiodev *sdev = adapter->rsi_dev;
>         struct ieee80211_hw *hw = adapter->hw;
> @@ -1509,10 +1508,10 @@ static struct sdio_driver rsi_driver = {
>         .name       = "RSI-SDIO WLAN",
>         .probe      = rsi_probe,
>         .remove     = rsi_disconnect,
> +       .shutdown   = pm_ptr(rsi_shutdown),
>         .id_table   = rsi_dev_table,
>         .drv = {
>                 .pm = pm_ptr(&rsi_pm_ops),
> -               .shutdown = pm_ptr(rsi_shutdown),

Apologize for my ignorance, but why does an SDIO function driver need
a ->shutdown() callback in the first place?

What does it need to do during shutdown?

>         }
>  };
>  module_sdio_driver(rsi_driver);
> --
> 2.47.3
>

Kind regards
Uffe