linux-kernel - Re: [PATCH 1/2] fs: Describe @isnew parameter in ilookup5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <w3tm4tlylon4wm3tjty46psodlloqy6nxfnp3xbxgpu46i6jm2@455xekzztppc>
Date: Fri, 19 Dec 2025 14:50:24 +0100
From: Jan Kara <jack@...e.cz>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Filesystems Development <linux-fsdevel@...r.kernel.org>, Alexander Viro <viro@...iv.linux.org.uk>, 
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, Mateusz Guzik <mjguzik@...il.com>, 
	Jeff Layton <jlayton@...nel.org>, NeilBrown <neil@...wn.name>, Amir Goldstein <amir73il@...il.com>
Subject: Re: [PATCH 1/2] fs: Describe @isnew parameter in ilookup5_nowait()

On Fri 19-12-25 09:46:19, Bagas Sanjaya wrote:
> Sphinx reports kernel-doc warning:
> 
> WARNING: ./fs/inode.c:1607 function parameter 'isnew' not described in 'ilookup5_nowait'
> 
> Describe the parameter.
> 
> Fixes: a27628f4363435 ("fs: rework I_NEW handling to operate without fences")
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/inode.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/inode.c b/fs/inode.c
> index 521383223d8a45..379f4c19845c95 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -1593,6 +1593,9 @@ EXPORT_SYMBOL(igrab);
>   * @hashval:	hash value (usually inode number) to search for
>   * @test:	callback used for comparisons between inodes
>   * @data:	opaque data pointer to pass to @test
> + * @isnew:	return argument telling whether I_NEW was set when
> + *		the inode was found in hash (the caller needs to
> + *		wait for I_NEW to clear)
>   *
>   * Search for the inode specified by @hashval and @data in the inode cache.
>   * If the inode is in the cache, the inode is returned with an incremented
> -- 
> An old man doll... just what I always wanted! - Clara
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR