linux-kernel - Re: [PATCH bpf-next v3 3/6] bpf: fix the usage of BPF_TRAMP_F_SKIP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cy4aeg56.fsf@igel.home>
Date: Fri, 19 Dec 2025 14:48:53 +0100
From: Andreas Schwab <schwab@...ux-m68k.org>
To: Menglong Dong <menglong.dong@...ux.dev>
Cc: ast@...nel.org,  Menglong Dong <menglong8.dong@...il.com>,
  rostedt@...dmis.org,  daniel@...earbox.net,  john.fastabend@...il.com,
  andrii@...nel.org,  martin.lau@...ux.dev,  eddyz87@...il.com,
  song@...nel.org,  yonghong.song@...ux.dev,  kpsingh@...nel.org,
  sdf@...ichev.me,  haoluo@...gle.com,  jolsa@...nel.org,
  mhiramat@...nel.org,  mark.rutland@....com,
  mathieu.desnoyers@...icios.com,  jiang.biao@...ux.dev,
  bpf@...r.kernel.org,  linux-kernel@...r.kernel.org,
  linux-trace-kernel@...r.kernel.org,  linux-riscv@...ts.infradead.org
Subject: Re: [PATCH bpf-next v3 3/6] bpf: fix the usage of
 BPF_TRAMP_F_SKIP_FRAME

On Dez 19 2025, Menglong Dong wrote:

> diff --git a/arch/riscv/net/bpf_jit_comp64.c b/arch/riscv/net/bpf_jit_comp64.c
> index 5f9457e910e8..09b70bf362d3 100644
> --- a/arch/riscv/net/bpf_jit_comp64.c
> +++ b/arch/riscv/net/bpf_jit_comp64.c
> @@ -1134,7 +1134,7 @@ static int __arch_prepare_bpf_trampoline(struct bpf_tramp_image *im,
>  	store_args(nr_arg_slots, args_off, ctx);
>  
>  	/* skip to actual body of traced function */
> -	if (flags & BPF_TRAMP_F_ORIG_STACK)
> +	if (flags & BPF_TRAMP_F_CALL_ORIG)
>  		orig_call += RV_FENTRY_NINSNS * 4;

There are now three occurrences of that condition, and only the third
one uses orig_call.  How about merging them?

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."