linux-kernel - Re: [PATCH v4] mm, hugetlb: implement movable_gigantic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUVe7Q90PxGBCt9e@gourry-fedora-PF4VCD3F>
Date: Fri, 19 Dec 2025 09:19:25 -0500
From: Gregory Price <gourry@...rry.net>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-mm@...ck.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-team@...a.com,
	david@...nel.org, osalvador@...e.de, lorenzo.stoakes@...cle.com,
	Liam.Howlett@...cle.com, vbabka@...e.cz, rppt@...nel.org,
	surenb@...gle.com, mhocko@...e.com, corbet@....net,
	muchun.song@...ux.dev, laoar.shao@...il.com, brauner@...nel.org,
	jack@...e.cz, hannes@...xchg.org, mclapinski@...gle.com,
	joel.granados@...nel.org, David Hildenbrand <david@...hat.com>,
	Mel Gorman <mgorman@...e.de>, David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH v4] mm, hugetlb: implement movable_gigantic_pages sysctl

On Thu, Dec 18, 2025 at 04:55:38PM -0800, Andrew Morton wrote:
> On Thu, 18 Dec 2025 10:12:11 -0500 Gregory Price <gourry@...rry.net> wrote:
> 
> > This reintroduces a concept removed by:
> > commit d6cb41cc44c6 ("mm, hugetlb: remove hugepages_treat_as_movable sysctl")
> > 
> > This sysctl provides flexibility between ZONE_MOVABLE use cases:
> > 1) onlining memory in ZONE_MOVABLE to maintain hotplug compatibility
> > 2) onlining memory in ZONE_MOVABLE to make hugepage allocate reliable
> 
> My x86_64 allmodconfig blew up.
> 
> > ...
> >
> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -49,7 +49,6 @@
> >  #include "internal.h"
> >  #include "hugetlb_vmemmap.h"
> >  #include "hugetlb_cma.h"
> > -#include "hugetlb_internal.h"
> >  #include <linux/page-isolation.h>
> 
> What's that doing there?  I put it back.  Helped!
> 

erk, this must have been carried over from a forward port, when all
these things moved into hugetlb_sysfs.c - very sorry, I will be more
careful.

> But the build still failed because the patch refers to
> 
> 	extern int movable_gigantic_pages __read_mostly;
> 
> but forgot to define it.  v5, please ;)
> 
> 

doh, well that's just embarassing

Will sus this out and send v5, sorry for the time sink

~Gregory