linux-kernel - Re: [PATCH V2] mm/memremap: fix spurious large folio warning for FS-DAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f3e2e99-cf87-4498-93a7-700ecb42a2a9@kernel.org>
Date: Fri, 19 Dec 2025 15:14:53 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: John Groves <John@...ves.net>, Oscar Salvador <osalvador@...e.de>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: John Groves <jgroves@...ron.com>, "Darrick J . Wong" <djwong@...nel.org>,
 Dan Williams <dan.j.williams@...el.com>, Gregory Price <gourry@...rry.net>,
 Balbir Singh <bsingharora@...il.com>, Alistair Popple <apopple@...dia.com>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org, linux-cxl@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, Aravind Ramesh <arramesh@...ron.com>,
 Ajay Joshi <ajayjoshi@...ron.com>
Subject: Re: [PATCH V2] mm/memremap: fix spurious large folio warning for
 FS-DAX

On 12/19/25 13:37, John Groves wrote:
> From: John Groves <John@...ves.net>
> 
> This patch addresses a warning that I discovered while working on famfs,
> which is an fs-dax file system that virtually always does PMD faults
> (next famfs patch series coming after the holidays).
> 
> However, XFS also does PMD faults in fs-dax mode, and it also triggers
> the warning. It takes some effort to get XFS to do a PMD fault, but
> instructions to reproduce it are below.
> 
> The VM_WARN_ON_ONCE(folio_test_large(folio)) check in
> free_zone_device_folio() incorrectly triggers for MEMORY_DEVICE_FS_DAX
> when PMD (2MB) mappings are used.
> 
> FS-DAX legitimately creates large file-backed folios when handling PMD
> faults. This is a core feature of FS-DAX that provides significant
> performance benefits by mapping 2MB regions directly to persistent
> memory. When these mappings are unmapped, the large folios are freed
> through free_zone_device_folio(), which triggers the spurious warning.
> 
> The warning was introduced by commit that added support for large zone
> device private folios. However, that commit did not account for FS-DAX
> file-backed folios, which have always supported large (PMD-sized)
> mappings.
> 
> The check distinguishes between anonymous folios (which clear
> AnonExclusive flags for each sub-page) and file-backed folios. For
> file-backed folios, it assumes large folios are unexpected - but this
> assumption is incorrect for FS-DAX.
> 
> The fix is to exempt MEMORY_DEVICE_FS_DAX from the large folio warning,
> allowing FS-DAX to continue using PMD mappings without triggering false
> warnings.
> 
> Fixes: d245f9b4ab80 ("mm/zone_device: support large zone device private folios")
> Signed-off-by: John Groves <john@...ves.net>
> ---
> 
> Change since V1: Deleted the warning altogether, rather than exempting
> fs-dax.
> 
> === How to reproduce ===
> 
> A reproducer is available at:
> 
>      git clone https://github.com/jagalactic/dax-pmd-test.git
>      cd xfs-dax-test
>      make
>      sudo make test
> 
> This will set up XFS on pmem with 2MB stripe alignment and run a test
> that triggers the warning.
> 
> Alternatively, follow the manual steps below.
> 
> Prerequisites:
>    - Linux kernel with FS-DAX support and CONFIG_DEBUG_VM=y
>    - A pmem device (real or emulated)
>    - An fsdax namespace configured via ndctl as /dev/pmem0
> 
> Manual steps:
> 
> 1. Create an fsdax namespace (if not already present):
>     # ndctl create-namespace -m fsdax -e namespace0.0
> 
> 2. Create XFS with 2MB stripe alignment:
>     # mkfs.xfs -f -d su=2m,sw=1 /dev/pmem0
>     # mount -o dax /dev/pmem0 /mnt/pmem
> 
> 3. Compile and run the reproducer:
>     # gcc -Wall -O2 -o dax_pmd_test dax_pmd_test.c
>     # ./dax_pmd_test /mnt/pmem/testfile
> 
> 4. Check dmesg for the warning:
>     WARNING: mm/memremap.c:431 at free_zone_device_folio+0x.../0x...
> 
> Note: The 2MB stripe alignment (-d su=2m,sw=1) is critical. XFS normally
> allocates blocks at arbitrary offsets, causing PMD faults to fall back
> to PTE faults. The stripe alignment forces 2MB-aligned allocations,
> allowing PMD faults to succeed and exposing this bug.
> 
> 
>   mm/memremap.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/mm/memremap.c b/mm/memremap.c
> index 4c2e0d68eb27..63c6ab4fdf08 100644
> --- a/mm/memremap.c
> +++ b/mm/memremap.c
> @@ -427,8 +427,6 @@ void free_zone_device_folio(struct folio *folio)
>   	if (folio_test_anon(folio)) {
>   		for (i = 0; i < nr; i++)
>   			__ClearPageAnonExclusive(folio_page(folio, i));
> -	} else {
> -		VM_WARN_ON_ONCE(folio_test_large(folio));
>   	}
>   

LGTM

Acked-by: David Hildenbrand (Red Hat) <david@...nel.org>

-- 
Cheers

David