linux-kernel - [PATCH] sh: dma-sysfs: add missing put_device() in dma_create_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20251220062836.683611-1-lihaoxiang@isrc.iscas.ac.cn>
Date: Sat, 20 Dec 2025 14:28:36 +0800
From: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
To: ysato@...rs.sourceforge.jp,
	dalias@...c.org,
	glaubitz@...sik.fu-berlin.de,
	kay.sievers@...y.org,
	gregkh@...e.de
Cc: linux-sh@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>,
	stable@...r.kernel.org
Subject: [PATCH] sh: dma-sysfs: add missing put_device() in dma_create_sysfs_files()

If device_register() fails, call put_device() to drop the device
reference. Also, call device_unregister() if device_create_file()
fails.

Found by code review.

Fixes: dc6876a288cc ("sh: dma - convert sysdev_class to a regular subsystem")
Cc: stable@...r.kernel.org
Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
---
 arch/sh/drivers/dma/dma-sysfs.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/sh/drivers/dma/dma-sysfs.c b/arch/sh/drivers/dma/dma-sysfs.c
index 9f666280d80c..5695fd0a0cd7 100644
--- a/arch/sh/drivers/dma/dma-sysfs.c
+++ b/arch/sh/drivers/dma/dma-sysfs.c
@@ -134,8 +134,10 @@ int dma_create_sysfs_files(struct dma_channel *chan, struct dma_info *info)
 	dev->bus = &dma_subsys;
 
 	ret = device_register(dev);
-	if (ret)
+	if (ret) {
+		put_device(dev);
 		return ret;
+	}
 
 	ret |= device_create_file(dev, &dev_attr_dev_id);
 	ret |= device_create_file(dev, &dev_attr_count);
@@ -145,6 +147,7 @@ int dma_create_sysfs_files(struct dma_channel *chan, struct dma_info *info)
 
 	if (unlikely(ret)) {
 		dev_err(&info->pdev->dev, "Failed creating attrs\n");
+		device_unregister(dev);
 		return ret;
 	}
 
-- 
2.25.1