linux-kernel - Re: [PATCH v6 1/2] dt-bindings: media: i2c: Add os05b10 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PN0P287MB2019AEDA6DEE722A4174A1E99AB6A@PN0P287MB2019.INDP287.PROD.OUTLOOK.COM>
Date: Sat, 20 Dec 2025 08:59:01 +0000
From: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
To: Krzysztof Kozlowski <krzk@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>
CC: Elgin Perumbilly <elgin.perumbilly@...iconsignals.io>, Vladimir Zapolskiy
	<vladimir.zapolskiy@...aro.org>, Mauro Carvalho Chehab <mchehab@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Hans Verkuil <hverkuil@...nel.org>, Hans
 de Goede <hansg@...nel.org>, Mehdi Djait <mehdi.djait@...ux.intel.com>,
	André Apitzsch <git@...tzsch.eu>, Laurent Pinchart
	<laurent.pinchart@...asonboard.com>, Dongcheng Yan <dongcheng.yan@...el.com>,
	Sylvain Petinot <sylvain.petinot@...s.st.com>, Benjamin Mugnier
	<benjamin.mugnier@...s.st.com>, Hardevsinh Palaniya
	<hardevsinh.palaniya@...iconsignals.io>, Svyatoslav Ryhel
	<clamor95@...il.com>, Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
	Jingjing Xiong <jingjing.xiong@...el.com>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 1/2] dt-bindings: media: i2c: Add os05b10 sensor

>On 20/12/2025 07:37, Himanshu Bhavani wrote:
>> Hi Krzysztof,
>>
>>> On 19/12/2025 09:45, Himanshu Bhavani wrote:
>>>> From: Elgin Perumbilly <elgin.perumbilly@...iconsignals.io>
>>>>
>>>> Add bindings for Omnivision OS05B10 sensor.
>>>>
>>>> Add MAINTAINERS entry for Omnivision OS05B10 binding documentation
>>>>
>>>> Signed-off-by: Elgin Perumbilly <elgin.perumbilly@...iconsignals.io>
>>>> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
>>>> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
>>>> ---
>>>
>>>
>>> Nothing improved and you did not bother to respond to my comment.
>>
>>
>> In v5, you pointed out that the driver and bindings were mismatched with
>> respect to the reset GPIO.
>>
>> Based on that feedback, I corrected the driver by making the reset GPIO
>> optional. I also reviewed a previous patch series discussion, as suggested
>> here:
>> https://lore.kernel.org/linux-media/20250710210532.GE22436@pendragon.ideasonboard.com/
>>
>> In that thread, Laurent suggested that GPIOs should be made optional in the
>> driver, which is what I followed in this version.
>>
>> If I have still missed something or misunderstood the feedback, please let me
>> know and I will address it.
>
>I expected reply or change in the binding. None was there, so that's why
>you got questions.

No no, definitely not ignoring your comment,  you’re the boss here :)
 
Thanks for the review

Best Regards,
Himanshu