linux-kernel - Re: [PATCH v3 1/4] dt-bindings: usb: Add binding for Genesys Logic GL3590 hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251220-economic-gay-firefly-1873a9@quoll>
Date: Sat, 20 Dec 2025 10:17:30 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Swati Agarwal <swati.agarwal@....qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Icenowy Zheng <uwu@...nowy.me>, 
	Matthias Kaehlcke <mka@...omium.org>, J . Neuschäfer <j.ne@...teo.net>, 
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, Jens Glathe <jens.glathe@...schoolsolutions.biz>, 
	Mike Looijmans <mike.looijmans@...ic.nl>, Catalin Popescu <catalin.popescu@...ca-geosystems.com>, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Pin-yen Lin <treapking@...omium.org>, linux-usb@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: usb: Add binding for Genesys Logic
 GL3590 hub

On Sat, Dec 20, 2025 at 12:05:34PM +0530, Swati Agarwal wrote:
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - usb5e3,625
> +    then:
> +      properties:
> +        peer-hub: true
> +        vdd-supply: false

This is not true. I clearly see VP33, AVDD and VP10 (and maybe more)
supplies. Not only in pin list, but high level diagram clearly marks two
supplies.

Please read again datasheet carefully, because that's your task, not
mine. I do not have even access to most of the datasheets, so  you
expecting me to do it is just unfair.

Best regards,
Krzysztof